changes the quantum telescope to use landmarks instead of hard coords #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k/lrt) instead of coordinates, fixing a bug with hardcoded coordinates for lrt locations
ZeWaka
added
P-Major
|
the map edits are me placing down an instance of /obj/landmark/lrt/gemv on the geminorum v start telepad, and an instance of /obj/landmark/lrt/workshop on the hidden workshop start platform |
pali6
approved these changes
Apr 11, 2020
|
Just for the future, write changelog so it's readable by a player. |
TobleroneSwordfish
added a commit
to TobleroneSwordfish/goonstation
that referenced
this pull request
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
makes the quantum telescope use landmarks (/obj/landmark/lrt/gemv, for example) instead of
keeping track of things with hardcoded coordinates. this also fixes #167 , which was caused by hardcoded lrt coordinates not being changed when areas on z2 were shuffled around. i also tested this to make sure it worked. (also in the future if you add lrt locations, please use the landmarks tia)
Why's this needed?
this fixes a bug that kinda sucked, and also is a lot better from a code maintainability perspective.
Changelog