Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notes commands #18532

Merged
merged 2 commits into from Apr 18, 2024
Merged

Conversation

FlameArrow57
Copy link
Contributor

@FlameArrow57 FlameArrow57 commented Apr 16, 2024

[PLAYER ACTIONS][QoL]

About the PR

Improves some things about the notes commands players can use in the Commands tab

-Renames
"Add Note" -> "Notes - Modify"
"Notes" -> "Notes - View"
so that they appear next to each other rather than in different spots (since names are sorted alphabetically)

-Improves Add Note command so that instead of only being able to add individual notes one at a time, your notes are just stored in a single string, changed through a big text box, and can be added/removed
notes 2

-Uses TGUI prompts for the commands now so that "Notes - Modify" uses a tgui_input_text and "Notes - View" uses a tgui_message
notes 3

Why's this needed?

QoL improvements and TGUI prompts

Changelog

(u)FlameArrow57
(+)Renamed notes commands in the Commands tab to "Add Note" -> "Notes - Modify" and "Notes" -> "Notes - View". "Notes - Modify" now allows you to add/remove notes all at once, rather than just adding one note at a time.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2024
@keywordlabeler keywordlabeler bot added A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-QoL A quality of life improvement that makes the game easier to play labels Apr 16, 2024
@FlameArrow57 FlameArrow57 changed the title Improve Notes commands Improve notes commands Apr 16, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 16, 2024
@github-actions github-actions bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2024
@Valtsu0
Copy link
Contributor

Valtsu0 commented Apr 17, 2024

I'd rather these be combined into a single verb/ui.

Though that is scope creep and these are better than the current ones

Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TobleroneSwordfish TobleroneSwordfish merged commit fe9d46e into goonstation:master Apr 18, 2024
24 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-QoL A quality of life improvement that makes the game easier to play size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants