Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify charcoal recipe a little #18657

Merged

Conversation

TobleroneSwordfish
Copy link
Contributor

[CHARCOAL] (I typed this instead of [CHEMISTRY] and it made me laugh so now it stays here)

About the PR

Simplifies the recipe for charcoal to just be (1) carbon + (1) ash = (1) charcoal + (1) steam (the ash is damp or something okay) with a secondary recipe of (1) carbon + (1) ash + (2) steam = (4) charcoal
The idea is that if you make it in an open container the steam evaporates and you lose yield compared to making it in a closed container.

Why's this needed?

Starting to address some of the rough edges of the chemistry rework. Someone asked in discord earlier how charcoal is made and I realised the explanation should not take half a page for a very basic medical chem. This version removes the common "all my charcoal vanished :(" complaint and brings the recipe more in line with its in-game level of power/complexity.

Changelog

(u)LeahTheTech
(*)Simplified the charcoal recipe: (1) Carbon + (1) Ash => (1) Charcoal + (1) Steam, with additional charcoal yield if the steam is prevented from evaporating.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 27, 2024
@keywordlabeler keywordlabeler bot added the A-Chemistry Deals with the chemistry system in some way label Apr 27, 2024
@TobleroneSwordfish TobleroneSwordfish added C-Balance Balance changes, buffs and nerfs E-Add-To-Wiki A PR that will require changes to the wiki labels Apr 27, 2024
@Flaborized
Copy link
Contributor

I think this is a fine change and I probably overtuned charcoal's recipe a bit, though I think the whole 'use condensers to pipe steam into a reaction' idea is Cool and could be re-utilized for some other recipe (if not the Super Basic Healing Chem one)

@TobleroneSwordfish TobleroneSwordfish merged commit ab3299a into goonstation:master Apr 28, 2024
25 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 28, 2024
@Studenterhue Studenterhue removed the E-Add-To-Wiki A PR that will require changes to the wiki label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Chemistry Deals with the chemistry system in some way C-Balance Balance changes, buffs and nerfs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants