-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change stats shown in gun tooltips #18854
Conversation
Doesn't this just make it impossible in turn to tell relative strengths of stun weapons (e.g.: the various taser types etc.) without code diving or wiki checking? |
Yea second guessing that part now... Looking at the code even now though, stun stat is a bit unclear as to what it does, seems to do stamina damage based off a clamped value (clamp(stun * 4, P.proj_data.stun * 2, stun + 80). Differs for gunbots specifically versus other mobs. Maybe this could be turned into a proc (to get base, min, or max stamina damage), and added to the tooltip to show stamina damage if that sounds good? Was seeing rubber slug shells show 30 power, 16.67% lethality and was thinking showing damage and stamina separately would maybe be easier to see? Rather than needing to do math in your head, and stun value is a bit unclear |
probably dumb question: how will this affect "spreader" projectiles, like pipeshot and birdshot? |
It'll show stats of an individual projectile in the spread. Seems to not work correctly tho for those types (shows stats of spreader projectile), think it could be fixed in another PR tho, slightly out of scope for this one (general bug fix) |
[GAME OBJECTS][REWORK][QoL]
About the PR
This PR changes up the stats shown in weapon tooltips for guns
Currently guns display:
Bullet power - Lethality %
Changes them to display:
Max stamina dmg (only shown if not 0) (versus someone with no disorient/stun protection)
Damage - Armor pierce % (AP only shown if not 0)
Pod disruption - Chance % (Only shown if not 0)
Why's this needed?
Gun stats currently display bullet force and lethality %. Without looking at the code, these numbers are pretty arbitrary as to what they mean I think? Also not a lot of weapons have stun to them, think it makes the power stat a little confusing in some cases
Showing just damage I think would make it easier to know a gun's damage without needing to look at the wiki, or have game knowledge, of what it is. Also, a non-trivial number of guns have armor pierce and pod disruption chance, which isn't visible to anyone without the wiki or code diving. Think it would be fun to show them
Changelog