Deployable turrets eject bullet casings #18987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keywordlabeler
bot
added
C-Feature
github-actions
bot
added
the
size/M
keywordlabeler
bot
added
the
A-Game-Objects
|
These things do have infinite ammo so I kinda worry about generating an infinite pile of casings if the turret gets stuck shooting a cockroach or something. Maybe start deleting them when they go over a certain amount on one tile? |
Tarmunora
approved these changes
May 20, 2024
|
I added something simple to make it start deleting casings once too many turf contents have been reached, LMK if something more involved is wanted |
ZeWaka
approved these changes
May 26, 2024
github-actions
bot
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[GAME OBJECTS][FEATURE][REWORK]
About the PR
This PR makes it so that deployable turrets (N.A.R.C.S./NARCS and NAS-T) eject bullet casings. They now have a forensics profile too, to match with their casings
Also does a minor rework of variables/procs internally to make it work
Why's this needed?
Thought it would be a fun effect
Changelog