Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rockworms never actually "digesting" the rocks they eat #18995

Merged

Conversation

MeggalBozale
Copy link
Contributor

@MeggalBozale MeggalBozale commented May 18, 2024

About the PR

Did you know that rockworms pooping vomiting gems after eating stuff was broken this whole time? I didn't!

This PR modifies the removing of the subtask to actually... do that, so they vomit out gems and uqill and stuff

To explain the bug that was happening as I did in the Discord:

It ate, but it was eating like any other critter would eat. It had tasks in the following order:
[1] wander
[2] eat (critter)
[3] eat (rockworm)
so first it wanders to a rock, then it eats the rock (qdel and all), then it tries to eat the rock again, and do the special code things that increment the rockworm's variable for how much of rocks it ate so far

Why's this needed?

image
Lets this feature actually work ;P

Changelog

(u)MeggalBozale
(+)Rockworms properly eat rocks again.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2024
@MeggalBozale MeggalBozale added A-AI Deals with some sort of mob or critter AI in the game C-Bug A bug that impacts usage of a feature labels May 18, 2024
@TobleroneSwordfish TobleroneSwordfish merged commit 67386ec into goonstation:master May 19, 2024
25 checks passed
github-actions bot pushed a commit that referenced this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-AI Deals with some sort of mob or critter AI in the game C-Bug A bug that impacts usage of a feature size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants