Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Held items are preserved for non-roundstart antags and freezernerds #1900

Merged
merged 11 commits into from Aug 25, 2020

Conversation

Superlagg
Copy link
Contributor

@Superlagg Superlagg commented Aug 22, 2020

[FEATURE]

About the PR

If you were an antagonist at any point in the round (ganged, mindslaved, etc.) or finished the round in the cryothingy, your held item is preserved.

Why's this needed?

I felt it was kinda odd that roundstart antags get to keep their spacebux purchases even if they don't escape, but most other antags don't. I like to do bad things and die as a non-roundstart baddie, but I don't like having to spend another 3k cus of it.

Plus the cryothing is basically a glorified locker that makes you blind and protected from sims. I think it'd work nice as a soft-quit from the round, where like you gotta go, but you don't want to just ditch your lizard.

PS: I dont know if this really works, cross-round spacebux things don't seem to work properly on local. vsc promises me the right vars are getting set, so maybe it works.

Changelog

(u)Superlagg:
(+)You now keep your held item if you were an antag at any point in the round, or you finish the round in the cryotron.

@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Aug 22, 2020
code/datums/gameticker.dm Outdated Show resolved Hide resolved
@pali6 pali6 merged commit a059c98 into goonstation:master Aug 25, 2020
github-actions bot pushed a commit that referenced this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants