Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "ants" reagent to foods that have spawned ants & makes fridges ant-safe #19049

Merged
merged 5 commits into from
May 31, 2024

Conversation

Glamurio
Copy link
Contributor

[QoL] [Feature]

About the PR

Adds 5 units of "ants" to any food that has spawned ants.

Adds /obj/storage/secure/closet/fridge to the list of turfs that spawn ants from blocking, as it's always been comical that an opened fridge would cause ants to swarm it.

Renames on_table to ant_safe, as that seems more descriptive by now.

Why's this needed?

Ants are a fun chem that never gets used. Also people routinely just ignore ants on their food. This should add a little more incentive to put food on tables, and is otherwise just a minor inconvenience to people who ignore ants on their food.

Changelog

(u)Glamurio (Ryou)
(*)Food left on the floor will now contain ants. Don't leave your food on the floor, people.

@keywordlabeler keywordlabeler bot added C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play labels May 20, 2024
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 20, 2024
@flappybatpal
Copy link
Contributor

Good idea.

@M-Earthfire
Copy link
Contributor

M-Earthfire commented May 20, 2024

Incoming all food in botany be contaminated with ants.

Dunno about this from the botany side of things. It would promote using produce satchel for harvesting, but that is sadly not that well documented. So i think that could run into problems with beginner botanists.

then again, we could just try implementing it and changing produce to be a bit easier to handle without ants getting onto it, if it really causes problems.

@Glamurio
Copy link
Contributor Author

Incoming all food in botany be contaminated with ants.

Dunno about this from the botany side of things. It would promote using produce satchel for harvesting, but that is sadly not that well documented. So i think that could run into problems with beginner botanists.

then again, we could just try implementing it and changing produce to be a bit easier to handle without ants getting onto it, if it really causes problems.

Could certainly make exceptions to produce, but also ants won't show up until 3 minutes have passed. If you leave food on the ground for 3 minutes, even in botany, then I would argue you weren't paying attention.

@M-Earthfire
Copy link
Contributor

Could certainly make exceptions to produce, but also ants won't show up until 3 minutes have passed. If you leave food on the ground for 3 minutes, even in botany, then I would argue you weren't paying attention.

That's a good point. What i pointed out was sonething to look out for after it's been merged

@DisturbHerb
Copy link
Contributor

eat ant

@RelentlessGarbage
Copy link

RelentlessGarbage commented May 20, 2024

Some feedback; it should be made obvious that an article of food with ants on it (unless said ants have been injected into the food) should have some kind of tell that there are ants (e.g. an "Ant-covered" prefix). The ants are obvious on the floor, they should be obvious on the food as well, unless they were added in a clandestine manner.

I'd argue that food quality should also be decreased by getting covered in ants and the ants should be removed if the food is washed, but that is scope creep. What matters most is that players either have a tell in the description or the item sprite that a food item has ants in it. If someone handed you an apple covered in ants, you'd probably notice.

EDIT: Does the addition of ants play well with the existing reagent capacities of food items? As in, will the ants "fit" into the limited reagent capacity most foods have with the current implementation?

@Glamurio
Copy link
Contributor Author

Glamurio commented May 20, 2024

Some feedback; it should be made obvious that an article of food with ants on it (unless said ants have been injected into the food) should have some kind of tell that there are ants (e.g. an "Ant-covered" prefix). The ants are obvious on the floor, they should be obvious on the food as well, unless they were added in a clandestine manner.

This seems like a cool idea. I'll see to adding that.

I'd argue that food quality should also be decreased by getting covered in ants and the ants should be removed if the food is washed, but that is scope creep. What matters most is that players either have a tell in the description or the item sprite that a food item has ants in it. If someone handed you an apple covered in ants, you'd probably notice.

Quality of food decrease is a cool idea but not in this PR. Not sure if washing off ants makes sense; they kind of go everywhere and it's impossible to fully remove every ant from every food. You can totally just remove them via syringe right now, technically.

EDIT: Does the addition of ants play well with the existing reagent capacities of food items? As in, will the ants "fit" into the limited reagent capacity most foods have with the current implementation?

Currently it just does a regular add_reagent() call, which already checks that it can't go over the maximum, so yeah.

@frawhst
Copy link
Member

frawhst commented May 28, 2024

Honestly I'd remove some chems from the food, as the ants are 'eating' them. That also means that foods which don't have extra space in their reagent capacity will be able to have ants in them. Maybe just remove 5 units of chems before adding the ants?

Code looks fine, though, and I'm in support of this in general.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2024
Copy link
Contributor

@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label May 29, 2024
@Glamurio Glamurio requested a review from Azrun May 31, 2024 13:25
@TobleroneSwordfish TobleroneSwordfish merged commit ce02efb into goonstation:master May 31, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request May 31, 2024
@Glamurio Glamurio deleted the ant_food branch June 5, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants