Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifact pitcher fix #1920

Merged
merged 7 commits into from Aug 24, 2020
Merged

artifact pitcher fix #1920

merged 7 commits into from Aug 24, 2020

Conversation

zjdtmkhzt
Copy link
Contributor

@zjdtmkhzt zjdtmkhzt commented Aug 24, 2020

About the PR

This makes it so that the artifact pitcher can actually activate force artifacts properly now, via adding some temporary throwforce to the thrown object based on the pitchers power.
The added throwforce scales from 0-25. Force artifact triggers go from 3-30, so if you use an object with at least 5 throwforce, you should be able to activate any force artifact now using the pitcher.

I also believe that the impactpad stand did not actually transfer force stimuli to the held artifact, I have rectified this as well.

In addition, the artifact control window for admins now shows the triggers for artifacts (if they have any).
Hopefully this should make testing stuff like this less of a pain.

Why's this needed?

It's good if features that are in the game actually work in the way they should.
closes #1812

Changelog

(u)zjdtmkhzt:
(+)The pitcher in the artifact lab should now actually scale its power properly for force artifacts.

@zjdtmkhzt zjdtmkhzt added P-Major A bug that significantly impacts the usage of a feature. C-Feature A new feature or enhancements to existing features labels Aug 24, 2020
@pali6
Copy link
Member

pali6 commented Aug 24, 2020

I hope someone manages to build an evil contraption using scanned and built pitchers on max throwforce.

@pali6 pali6 merged commit f3beb6e into goonstation:master Aug 24, 2020
github-actions bot pushed a commit that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features P-Major A bug that significantly impacts the usage of a feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Artifact Lab pitcher is mostly pointless
2 participants