Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes bodies not decompose in space #2001

Closed
wants to merge 1 commit into from
Closed

Conversation

pali6
Copy link
Member

@pali6 pali6 commented Aug 30, 2020

About the PR

This PR makes decomposition not happen if the body is in space (or in a container that's in space).

(Also some very mild code cleanup.)

Why's this needed?

I like the tradeoff this creates. Throwing a dead body into space is usually very easy and makes the body relatively hard to find. Making those space bodies cloneable would be the downside to this common strategy.

Changelog

(u)pali
(+)Bodies no longer decompose in space.

@pali6 pali6 added C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Aug 30, 2020
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=14978

@pali6 pali6 marked this pull request as draft August 30, 2020 16:49
@pali6
Copy link
Member Author

pali6 commented Aug 30, 2020

Turns out that decomposition is dumb and needs fixing.

@pali6
Copy link
Member Author

pali6 commented Aug 30, 2020

Actually I'll just make a separate PR for that.

@pali6 pali6 closed this Aug 30, 2020
@pali6 pali6 deleted the no-decomposition-in-space branch August 30, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant