Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprites a large chunk of the ore #210

Merged
merged 2 commits into from Apr 12, 2020
Merged

Resprites a large chunk of the ore #210

merged 2 commits into from Apr 12, 2020

Conversation

Flaborized
Copy link
Contributor

About the PR

Resprites a bunch of the raw ore, including mauxite, pharosium, uqill, ice, char, molitz, erebite, corbyl, claretine, telecrystal, cerenkite, plasmastone, syreline, bohrum, fibrilith, starstone and gold.

Why's this needed?

A lot of the current ore sprites are just kinda undefined circular shapes, I think it'd be better if htey looked like how I drew them instead of how they look currently. I tried to keep them either roughly the same shape or similar to what they're based off of (for example molitz looks more like a bit of quartz crystal cuz that's how it's described in-game) to keep them identifiable. Feedback is appreciated on these.

Changelog

Flaborized:
* Resprited a bunch of the ore in the game!

@Adharainspace
Copy link
Contributor

these look way cool!!!

@ZeWaka ZeWaka added the C-Sprites Automatically applied on any .dmi or icons folder change label Apr 12, 2020
@flrsh
Copy link
Contributor

flrsh commented Apr 12, 2020

Really nice sprites, I think you captured the personalities of a lot of the ores super well. My only suggestions would be to make syreline more expensive looking (in Mineralogy 101, it's described as "an alloy of several precious metals and having beautiful light refracting and reflecting properties in its natural state") and to maybe give starstone some sort of animation so it stands out a bit more?

@Flaborized
Copy link
Contributor Author

Really nice sprites, I think you captured the personalities of a lot of the ores super well. My only suggestions would be to make syreline more expensive looking (in Mineralogy 101, it's described as "an alloy of several precious metals and having beautiful light refracting and reflecting properties in its natural state") and to maybe give starstone some sort of animation so it stands out a bit more?

I gave starstone and syreline a little shining animation! to indicate their value. Old syreline had one like this but I thought it looked a bit silly with the actual sparkles, but now I'm of the mind that it's funny that it sparkles twice

@ZeWaka ZeWaka merged commit 4e5bf62 into goonstation:master Apr 12, 2020
ZeWaka added a commit that referenced this pull request Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Sprites Automatically applied on any .dmi or icons folder change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants