New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes Apiculturist into a daily job on Mondays and makes mime a regular job selectable via job preferences #2387
Conversation
People like to play mime mime is very fun after all but they are a late join job only meaning mime is rare and antag mimes are even rarer this pr makes it so you can select mimes from job selection to hopefully remedy the issue by allowing people the chance to regularly play mime and even opening up opportunities for antagonist shenanigans
might possibly break for things using the path, I'd imagine the special job thing does |
anyway to test if it does? or how to fix it? |
Input needed label? |
ok how do i put the label on it? |
Created discussion thread: https://forum.ss13.co/showthread.php?tid=15194 |
If I understood you correctly, on the forums you said that it's still possible to get a 2nd Mime on Mondays. If that's the case then I'd probably say that should probably get fixed to not be the case |
what would i fix that with? who would replace the mime? im no super coder and i cant sprote so i dont think i could replace mime job on mondays |
that'll break stuff more, now that monday doesn't exist |
fuck how do i bring back mondays? also should i just close this and hope someone who an actually code will do it properly? |
You could probably take one of the jobs from the randomised jobs (look under line 1287) and put it in place of the mime's Monday slot. Just remember to remove the random jobs entry. Also, I think this is a change worthy of a changelog. If you're out of ideas, maybe write something like how the Mime has finally gotten a promotion and is now a full-time NanoTransen employee |
ill do that then also how do i revert the commit where i deleted mondays as a whole? |
no need to revert, just rewrite and commit what you have so that it replaces the Monday job. |
basically replaced the monday job with conworker which is now a daily job i think this will stop or at least mitigate people picking conworker just to do criminal crimes
done i picked conworker because honestly i think the rcd deluxe is far far to strong to have every day and is very often misused in ways which harm the crew as a whole if anyone disagrees with this i would be happy to change it to another job. |
Consider updating the PR description to reflect that change as well. |
I like mimes However I very much dislike outright removing conworker from the list of roundstart jobs, I have not noticed many cases of abusing this job and I definetly have witnesses many conworkers working on fun creative projects. It'd be sad to see it gone I'd just add some latejoin role as a monday job instead of messing with existing job list |
As far as I was aware, having tried with favourite etc that roundstart conworker doesn't work/is bugged? I remember poking about it back near when I started and was told by an admin to latejoin in order to be a conworker. Happy to be wrong though if this isn't the case anymore? |
im adding the conworker gear to engi lockers and the ce will get the rcd deluxe so you can still conworker edit: that should come in a seperate pr later this one should focus on mimes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
push an empty commit to restart the checks please. map one is broken |
Not really a big fan of this change. |
Mimes not being able to speak is bad gameplay, in my opinion. Less ability to interact with the crew tends to push people into more borderline griefy behaviors. |
Closing due to discussion with developer team, and we have decided to not merge this PR. Currently, mimes have no unique mechanics and thus don't really have a spot as a full job. Furthermore, mimes aren't generally 'good' for the current gameplay, since they don't have good mechanics to interact with other players, which often leads to grief-ish behavior. |
About the PR
this will make apiculturist daily job limited to Mondays and make the mime selectable via job preferences
Why's this needed?
We have a lot of new bees recently so they will need someone to look after them
Changelog`