Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secbots are louder and have a delay before they attack #2460

Merged
merged 4 commits into from Nov 3, 2020

Conversation

Superlagg
Copy link
Contributor

About the PR

Secbots no longer instantly attack the moment they get in range of whatever they want to kill. Instead, they stop, spend a couple seconds to charge their baton, then try to stun their target. If that person is still right next to them when their thing is charged, they'll stun them, but if not, they'll chase after their target, and if they reach them within a second, they instantly zap them.

The secbot siren thing has been moved to its own proc, and is called in several places when in pursuit. Now there's no doubt about whether Beepsky's running someone down!

Also, non-beepsky secbots take 8 seconds to cuff someone, up from 6.

Why's this needed?

Secbots were awful to fight, and I think that their role should be to force badguys to keep moving, as opposed to outright catching them. Also, I like obnoxious noises.

Changelog

(u)Superlagg:
(*)Secbots no longer instantly zap you the moment they get in range. Instead, they take a moment to charge their baton, then zap you!
(+)Every secbot, except for Officer Beepsky, forgot to attend mandatory handcuff training, and thus now take 8 seconds to cuff someone.

@Superlagg Superlagg added C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. C-Rework Reworks a feature labels Oct 19, 2020
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=15255

@Kyle2143
Copy link
Contributor

Wanna also make secbots absorb weapons fire? Or at least when they get hit by the projectile? Not that it's particularly a nerf like is, but I've always felt like they should because shooting at them feels unresponsive.

@Superlagg Superlagg force-pushed the secbotnerf branch 2 times, most recently from 35f5a4d to 7e7e29f Compare October 31, 2020 23:04
@Superlagg
Copy link
Contributor Author

Wanna also make secbots absorb weapons fire? Or at least when they get hit by the projectile? Not that it's particularly a nerf like is, but I've always felt like they should because shooting at them feels unresponsive.

Tried doing something like that, then I got distracted and made a bunch of projectile mob piercing code that accomplished this in a roundabout way. I'll probably implement that in a later PR, since it'll have to end up messing with projectile code if I don't want to make secbots dense.

Copy link
Member

@ZeWaka ZeWaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good

code/modules/robotics/bot/secbot.dm Outdated Show resolved Hide resolved
break
else
continue

proc/weeoo()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be named weewoo

Co-authored-by: ZeWaka <zewakagamer@gmail.com>
@ZeWaka ZeWaka merged commit d138fb7 into goonstation:master Nov 3, 2020
github-actions bot pushed a commit that referenced this pull request Nov 3, 2020
ZeWaka added a commit that referenced this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features C-Rework Reworks a feature E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants