Reworks Janitor job rewards to require a sacrificial item #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carbadox
added
the
C-Code-Quality
ZeWaka
reviewed
Nov 30, 2020
| @@ -114,13 +114,21 @@ mob/verb/checkrewards() | |||
| desc = "A bucket! And it's red! Wow." | |||
| required_levels = list("Janitor"=5) | |||
| claimable = 1 | |||
| claimPerRound = 1 | |||
There was a problem hiding this comment.
why remove the per round - for both
There was a problem hiding this comment.
why remove the per round - for both
I assume because "making a bucket/mop out of thin air should be limited per round, whereas making your bucket/mop look different isn't really abusable".
ZeWaka
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Reworks the orange mop and red bucket Janitor Job Rewards to require a regular mop and bucket respectively when claiming the rewards.
Why's this needed?
Because just making items pop out of thing air is a bit silly in this case. Also Im suprised I didn't get told off for this earlier.
Changelog