Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equips medical doctors with medical belts on spawn. #2985

Merged

Conversation

Carbadox
Copy link
Contributor

@Carbadox Carbadox commented Dec 8, 2020

About the PR

Give Medical Doctors medical belts already equipped onto them.

Why's this needed?

Medical doctors having to fight over storage space is dumb. This should make things easier for them

Changelog

(u)Carbadox
(*)Medical doctors now start with medical belts.

@Carbadox Carbadox added C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Dec 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

Created discussion thread: https://forum.ss13.co/showthread.php?tid=15506

slot_poc1 = /obj/item/paper/book/pocketguide/medical
items_in_backpack = list(/obj/item/crowbar, /obj/item/robodefibrillator) // cogwerks: giving medics a guaranteed air tank, stealing it from roboticists (those fucks)
slot_poc1 = /obj/item/device/pda2/medical
slot_poc2 = /obj/item/storage/medical_pouch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard disagree on adding the pouch. These are intended for Nuke Ops "Combat Medics", not regular doctors.

Comment on lines 136 to 141
/obj/item/storage/medical_pouch/medic //used by regular medical doctors
name = "medical pouch"
icon_state = "ammopouch-medic"
w_class = 1.00
slots = 4
does_not_open_in_pocket = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even the nerfed version seems ridiculously good - you're essentially giving doctors another 3 pockets. Strong disagree on adding this.

@Gerhazo
Copy link
Contributor

Gerhazo commented Dec 8, 2020

Don't personally think inventory management needs to be trivialized further or that the change's necessary.

Personal opinions aside, as some input in terms of code, with the original currently existing /obj/item/storage/medical_pouch being present for nukeops and an /obj/item/storage/medical_pouch/medic that this PR adds being intended for regular use, it'd probably make more sense to have the architecture be structured the other way around, with /obj/item/storage/medical_pouch for the more general regular pouch and /obj/item/storage/medical_pouch/syndicate (or some other wording of the sort to reflect nuclear operatives, probably in line with what other nukeop-labeled things in code are) for the more specific sort of medical pouch.
At least that's what I think would be more optimal and self-descriptive pathing requiring no use of "used by regular doctors" code comments.

@ghost
Copy link

ghost commented Dec 9, 2020

I strongly agree with the medical belt part, as Engineers and Mechanics start with Utility Belts and yet Medical Staff have to fight over Medical Belts and there's rarely more than 2-3 depending on the map. The pouch I however strongly disagree with. While nice, it's a bit too much.

@Carbadox Carbadox changed the title Equips medical doctors with medical belts and medical pouches on spawn. Equips medical doctors with medical belts on spawn. Dec 10, 2020
@mordent-goonstation mordent-goonstation merged commit 6c062db into goonstation:master Dec 10, 2020
github-actions bot pushed a commit that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants