Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machinery EMP Resistance (Wild Singulo Fixes) #3020

Merged
merged 4 commits into from Dec 27, 2020

Conversation

Azrun
Copy link
Contributor

@Azrun Azrun commented Dec 11, 2020

[balance][bug - major][input wanted]

About the PR

  • Singularities will no longer attempt to eat things that do not exist. [Bug]
  • Limits Camera's to only queue only recalculation when multiple EMPs have happened in the 90 second disable window. [Performance]
    • This does make it so you can not add additional delay until the cameras comes back online. [Balance]
  • Limits APC battery drain from EMP to once every 90 seconds. [Performance] [Balance]
    • Battery drain from EMP can be mitigated by turning off APC due to implementation [Balance]
  • Limits EMP on standard machinery to only procing overlay and power drain to once per second.

This does end up being an "unintentional" EMP Grenades, Wave Gun, EMP* nerf as there will be a limit to how often those items can impact /obj/machinery.


Addresses a number of runtimes that occur due to spawned tasks having their object disposed of.
Targets performance improvements when multiple EMPs go off to limit the number of new tasks spawned.

Why's this needed?

Runtimes are bad.
Resolve unusual behavior from multiple EMP's going off. Like when the station is covered in singularities...

(u)Azrun:
(+)Machinery, cameras, and APCs are more EMP resistant.  Cameras will come back online after being EMPed after 90 seconds, duration will no longer be extended with additional EMPs.

@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs C-Bug A bug that impacts usage of a feature P-Major A bug that significantly impacts the usage of a feature. E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. C-Performance Targets performance enhancements labels Dec 11, 2020
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=15511

@flrsh
Copy link
Contributor

flrsh commented Dec 11, 2020

Can you rephrase Will no longer be able to re-EMPs to reset duration that camera is disabled until it comes back online. so that it's more clear?

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Dec 11, 2020
…_nom_singlo

# Conflicts:
#	code/WorkInProgress/AnimationLibrary.dm
@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Dec 11, 2020
_std/machinery.dm Outdated Show resolved Hide resolved
@Azrun
Copy link
Contributor Author

Azrun commented Dec 24, 2020

@ZeWaka you want me to change it for consistency or is this pending anything else?

@Tarmunora Tarmunora merged commit 1c2e3b1 into goonstation:master Dec 27, 2020
@Azrun Azrun deleted the runtimes_from_nom_nom_singlo branch March 25, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs C-Bug A bug that impacts usage of a feature C-Performance Targets performance enhancements E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. P-Major A bug that significantly impacts the usage of a feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants