New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Machinery EMP Resistance (Wild Singulo Fixes) #3020
Merged
Tarmunora
merged 4 commits into
goonstation:master
from
Azrun:runtimes_from_nom_nom_singlo
Dec 27, 2020
Merged
Machinery EMP Resistance (Wild Singulo Fixes) #3020
Tarmunora
merged 4 commits into
goonstation:master
from
Azrun:runtimes_from_nom_nom_singlo
Dec 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… behavior and runtimes from singularities eating things
keywordlabeler
bot
added
C-Balance
Balance changes, buffs and nerfs
C-Bug
A bug that impacts usage of a feature
P-Major
A bug that significantly impacts the usage of a feature.
E-Input-Wanted
Input and feedback are wanted. Also posts a discussion thread on the forums.
C-Performance
Targets performance enhancements
labels
Dec 11, 2020
Created discussion thread: https://forum.ss13.co/showthread.php?tid=15511 |
Can you rephrase |
github-actions
bot
added
the
S-Merge-Conflict
Applied and removed when a PR has or no longer has a merge conflict
label
Dec 11, 2020
…_nom_singlo # Conflicts: # code/WorkInProgress/AnimationLibrary.dm
github-actions
bot
removed
the
S-Merge-Conflict
Applied and removed when a PR has or no longer has a merge conflict
label
Dec 11, 2020
ZeWaka
reviewed
Dec 14, 2020
ZeWaka
reviewed
Dec 15, 2020
@ZeWaka you want me to change it for consistency or is this pending anything else? |
ZeWaka
approved these changes
Dec 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-Balance
Balance changes, buffs and nerfs
C-Bug
A bug that impacts usage of a feature
C-Performance
Targets performance enhancements
E-Input-Wanted
Input and feedback are wanted. Also posts a discussion thread on the forums.
P-Major
A bug that significantly impacts the usage of a feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[balance][bug - major][input wanted]
About the PR
This does end up being an "unintentional" EMP Grenades, Wave Gun, EMP* nerf as there will be a limit to how often those items can impact /obj/machinery.
Addresses a number of runtimes that occur due to spawned tasks having their object disposed of.
Targets performance improvements when multiple EMPs go off to limit the number of new tasks spawned.
Why's this needed?
Runtimes are bad.
Resolve unusual behavior from multiple EMP's going off. Like when the station is covered in singularities...