Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heard name to looc messages #3102

Closed
wants to merge 1 commit into from
Closed

Add heard name to looc messages #3102

wants to merge 1 commit into from

Conversation

Lynncubus
Copy link
Contributor

@Lynncubus Lynncubus commented Dec 18, 2020

[input]

About the PR

Adds the mobs heard name to LOOC messages.

As far as i know you always have /mob, only thing this does is if you're still in the starting lobby your ckey will show up instead. So it should be safe?

Why's this needed?

Often find myself asking who someone is in LOOC if trying to have conversation there on the RP servers. This should take care of that. I don't think metagaming is a huge issue since most people already have a character name everyone recognizes. It could be a different story on the main servers though so there's the possibility of making this a thing only for the RP servers.

Changelog

(u)Luxizzle:
(+)Character name is now shown in LOOC messages.

@keywordlabeler keywordlabeler bot added the E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. label Dec 18, 2020
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=15552

@mordent-goonstation
Copy link
Contributor

Disagree with the feature, would look to go the other way instead (show character name in LOOC).

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2021

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jan 2, 2021
@pali6
Copy link
Member

pali6 commented Jan 6, 2021

I personally like it. I feel like a lot of the time LOOC chat is coupled with the character (i.e. asking if the other person is okay with something you are going to do etc.).

@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Jan 7, 2021
@Slazzy
Copy link

Slazzy commented Jan 9, 2021

Strongly agree with adding this - seems like a simple QOL improvement. I'd have no issue with removing the ckey entirely and just having character name. Ultimately, the purpose of LOOC is to inform other players of IRL/network issues that will impact an RP scenario, to ask permission/posit an RP scenario, or to help teach newer players with things that can't be done through ingame interactions (where you have to tell them to click on something/drag sprites, etc that can't be done through ingame means). Having a character name helps clarify all of these situations.

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jan 24, 2021
@pali6
Copy link
Member

pali6 commented Jan 26, 2021

What about making this a toggle (a verb in the commands tab maybe?) that starts off so you can identify yourself if you want but don't have to?

@Lynncubus
Copy link
Contributor Author

I can take a look at that. Have just been busy with other things at the moment and kind of forgot this was still here.

@Slazzy
Copy link

Slazzy commented Jan 26, 2021

I feel like a toggle removes a good portion of the utility this change is attempting to bring. From what I can see, any legitimate use of LOOC involves a player's character, not their arbitrary user name (planning out an RP, informing someone else of network issues, interactions between experienced/inexperienced players giving instructions).

What situations would someone benefit from having their ckey display without a character name?

@pali6
Copy link
Member

pali6 commented Jan 26, 2021

If the toggle is a no then it's probably better to show only the character name.

@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Jan 27, 2021
@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Feb 11, 2021
@github-actions github-actions bot closed this Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Stale An inactive PR that has had no updates in the past two weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants