Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mult support for machinery where applicable #3147

Merged
merged 1 commit into from Jan 6, 2021

Conversation

Azrun
Copy link
Contributor

@Azrun Azrun commented Dec 24, 2020

[balance][input wanted]

About the PR

Adding support for "mult" to various machinery to account for missed periodic processing incurred by what the people call "lag".

  • PT Laser charge and output scaling. (Buff)
  • SMES charge scaling (Buff)
  • Buttbot butt talk scaling (Buff?)
  • Robot Docking station charging scaling (Buff)
  • Cell Charge scaling. (Buff)
  • Radiation Collector “fuel” consumption scaling. (NERF)

Why's this needed?

Provides more consistent user experience by accounting for variability of machine processing. The goal is to err on the side of the player to avoid situations where overall processing delay doesn’t cause thrashing with the powernets as the overall behavior is non-deterministic.

This will be accomplished by scaling actions performed while ignoring scaling of power usage, as we can not be certain that scaling would also occur for machinery that would provide power to the powernet for the reset. (Would love for someone to tell me I’m wrong)

Atmos scaling is limited as suddenly influxes of activity would cause unusual behavior that would be impossible to rationalize from a player perspective and an absolute nightmare to debug and investigate.

(u)Azrun:
(+)Improve responsiveness of machinery during "lag". (PTL, SMES, Buttbots, Robot Docking Station, Cell Charger, Recharger) 

@Azrun Azrun marked this pull request as ready for review January 2, 2021 07:08
@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Jan 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2021

Created discussion thread: https://forum.ss13.co/showthread.php?tid=15583

@pali6 pali6 merged commit bf3851f into goonstation:master Jan 6, 2021
@Azrun Azrun deleted the mult_machinery branch March 25, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants