Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shaft material effects not applying and allows more materials #3409

Merged
merged 9 commits into from Feb 14, 2021
Merged

Fix shaft material effects not applying and allows more materials #3409

merged 9 commits into from Feb 14, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 20, 2021

[balance]

About the PR

This pr makes sure that both the shaft and head effects apply from an embedded arrow, it does this by making an alloy. Somehow removing this implanted arrow surgically returns the original arrow and not an alloyed version. This pr also allows you to make arrowshafts and spear shafts out of wood(and butts/pizza). Also allows you to make an arrowhead out of organic material like chitin or bone or wood or bamboo or whatever else you manage to find.

Why's this needed?

Arrowshafts not having material effects apply just feels bad if you dont know better than to use only steel for the shafts. This allows a bit more variety in arrow crafting and is more or less a bugfix. Added organic crafting to arrows to allow for wood arrows and such because wood seems like a normal material to make an arrow out of.

Changelog

(u)Anachroniser:
(+)Arrow shafts now apply effects while implanted
(+)Can use organic material in arrows and spears

@zjdtmkhzt
Copy link
Contributor

Hmm, I always felt like that was because the tip is the thing actually touching you and stuff? Especially once it is basically shrapnel.

@ghost
Copy link
Author

ghost commented Jan 20, 2021

Hmm, I always felt like that was because the tip is the thing actually touching you and stuff? Especially once it is basically shrapnel.

I mean, arrowheads are only an inch long generally. Arrows generally penetrate into flesh more than an inch so it seems reasonable to me.

@ZeWaka
Copy link
Member

ZeWaka commented Jan 21, 2021

please label your PRs

@keywordlabeler keywordlabeler bot added the C-Balance Balance changes, buffs and nerfs label Jan 23, 2021
@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Feb 11, 2021
@pali6 pali6 merged commit a67df08 into goonstation:master Feb 14, 2021
github-actions bot pushed a commit that referenced this pull request Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs S-Stale An inactive PR that has had no updates in the past two weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants