Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds action bar to power cell swapping #3418

Merged
merged 3 commits into from Feb 12, 2021

Conversation

Sord213
Copy link
Contributor

@Sord213 Sord213 commented Jan 21, 2021

[BALANCE]

About the PR

Adds a short action bar to power cell swapping

Why's this needed?

Right now swapping power cells is an instant effect and can be done on the move mid-combat. This would slightly slow down combat by making it a more active decision to swap your cell out when need be, rather than the current run and gun swap 5 cells out of your pocket it is now.

Changelog

(u)mbc and Sord:
(*)Added short action bar to power cell swapping

@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs WIP labels Jan 21, 2021
@PrimeNumb
Copy link
Contributor

As the person who added it in the first place, I'll admit it's kinda dumb when a security officer is hotswapping like 5 power cells and effectively having unlimited ammo for their taser. Good change; could possibly be an even longer duration but I guess we'll have to see how it plays out first.

@Carbadox
Copy link
Contributor

Carbadox commented Jan 21, 2021

Kinetic guns reload instantly but energy guns aren't supposed to?

🤔

Also this come of as a very reactionary change against a specific person

@PrimeNumb
Copy link
Contributor

Also if this is unfinished then consider making it a draft PR.

@pali6 pali6 marked this pull request as draft January 21, 2021 16:33
@flappybatpal
Copy link
Contributor

flappybatpal commented Jan 21, 2021

Kinetic guns reload instantly but energy guns aren't supposed to?

🤔

Also this come of as a very reactionary change against a specific person

No reason a similar thing couldn't be done although kinetic varies a lot in capacity so a one size fits all reload might not make sense.
Regardless, people generally say kinetic guns aren't very good.

@Tarmunora
Copy link
Member

Also this come of as a very reactionary change against a specific person

This came about as a result of internal discussion about power cells because of the inclusion of extra cells as utility items in #3413.

@Carbadox
Copy link
Contributor

Carbadox commented Jan 21, 2021

Kinetic guns reload instantly but energy guns aren't supposed to?

🤔

Also this come of as a very reactionary change against a specific person

No reason a similar thing couldn't be done although kinetic varies a lot in capacity so a one size fits all reload might not make sense.
Regardless, people generally say kinetic guns aren't very good.

That kind of change affects Nuclear Operatives as a whole too. Unless there was some sort of trait added that let Nukies reload instantly but in that case I don't see why Security wouldn't be eligible for a similar trait for energy weapons.

I don't see a correlation between what the PR wants to change and the example that's given. Learning to navigate your backpack and reload mid combat is a part of learning the game.

Someone who has 5 cells in his bag is sacrificing 5 inventory spaces which could be used to store other vital items, whether it's a medkit, stun baton, barrier, box of tools, lethal gun, bomb, box of drinking glasses with hellchems, hand tele, whatever.

If anything, removing the ability to reloading by smacking guns against ammo would resolve the issue presented

@Sord213
Copy link
Contributor Author

Sord213 commented Jan 21, 2021

That kind of change affects...

If down the line action bars were added to kinetic weapons there would be a bit more involved in balancing the reload times. Something like the LMG would most likely have a longer reload time but a pistol would be quick. But that's a discussion for another time.

Like Tarm said this wasn't aimed at anyone or any playstyle specifically, it was just a change that seemed pretty well needed in terms of balancing combat. Something like the NTSpecialO has a pouch with 5 power cells for their laser assault rifle. Adding a short timer to reloading where you have to stop moving in combat makes you have to think about your actions more. Same with tasers or eguns. You can't just magdump people then instantly swap cells and keep blastin.

Also this does not remove loading cells from your backpack or pouches or belts. That still functions. There's just a short timer added to the action.

@Sord213 Sord213 marked this pull request as ready for review January 21, 2021 22:16
@ZeWaka ZeWaka removed the WIP label Jan 30, 2021
code/obj/item/gun/ammo.dm Show resolved Hide resolved
code/obj/item/gun/ammo.dm Show resolved Hide resolved
code/obj/item/gun/ammo.dm Show resolved Hide resolved
code/obj/item/gun/ammo.dm Outdated Show resolved Hide resolved
code/obj/item/gun/energy.dm Outdated Show resolved Hide resolved
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
@Tarmunora Tarmunora merged commit ae24a75 into goonstation:master Feb 12, 2021
github-actions bot pushed a commit that referenced this pull request Feb 12, 2021
@Studenterhue Studenterhue added E-Add-To-Wiki A PR that will require changes to the wiki and removed E-Add-To-Wiki A PR that will require changes to the wiki labels Feb 26, 2021
@Sord213 Sord213 deleted the gunpowercell branch March 22, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants