Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetises letter component in book/vendor #3758

Merged
merged 2 commits into from Mar 4, 2021

Conversation

BatElite
Copy link
Contributor

@BatElite BatElite commented Feb 18, 2021

[cleanliness]

About the PR

Adds a 1 second delay to mechcomp teleporters activating. This is my first time introducing a SPAWN_DBG so hopefully it's in the right spot.

This PR moves the letter display's position in the mechcomp book and vendor under the LED component because as a general rule both of those are alphabetised.

Why's this needed?

Helps peeps find stuff easier

@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs C-Code-Quality Cleans up code, refactors things to be more readable or intuitive E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Feb 18, 2021
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Feb 18, 2021
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=15887

@mybluecorners
Copy link
Contributor

I like it, but using Spawn would make the period take longer when the game was lagging. maybe use action bar timers instead?
and if it was visually represented with a bar I think you could take the 'charge up' time lower to like 0.5 seconds since it wouldn't trigger on people running over it and would very quickly trigger if they stood still.

@BatElite
Copy link
Contributor Author

I've let this PR sit for a bit to see what reactions it gets, but surprisingly next to no-one in the thread likes the delay.

I'd look into the action bar thing, but with the response I'll probably instead soon remove the delay thing again and leave putting the letter component in the right spot.

@BatElite BatElite changed the title Adds 1 second mechcomp teleporter delay, alphabetises letter component in book/vendor Alphabetises letter component in book/vendor Mar 1, 2021
@BatElite BatElite removed C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. C-Sprites Automatically applied on any .dmi or icons folder change labels Mar 1, 2021
@ZeWaka ZeWaka merged commit dddddc2 into goonstation:master Mar 4, 2021
@BatElite BatElite deleted the mechcompteledelay branch January 19, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality Cleans up code, refactors things to be more readable or intuitive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants