Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows borgs to inherit the material of their frame #3791

Closed
wants to merge 1 commit into from

Conversation

zjdtmkhzt
Copy link
Contributor

@zjdtmkhzt zjdtmkhzt commented Feb 21, 2021

About the PR

This would allow borgs to inherit the material of their frame.
Some stuff would still need to be ironed out, I'd like to maybe make more materials trigger their effects on the mob itself when a mob is made out of that material, like for instance telecrystals.
Also, there are potential balance issues with erebite borgs, which can absorb about 20 or so of their own explosions before their limbs are destroyed, if they have a shield upgrade.

Why's this needed?

I think it'd be neat and fun! It might be a way for roboticists to put some extra customization on borgs, and it does kind of make sense from a logic standpoint that it'd be possible.

Changelog

(u)zjdtmkhzt
(*)Cyborgs now inherit the material of the frame used to make them.

@zjdtmkhzt zjdtmkhzt added C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Feb 21, 2021
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=15909

@zjdtmkhzt zjdtmkhzt added C-Feature A new feature or enhancements to existing features WIP labels Feb 21, 2021
@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label Mar 1, 2021
@ZeWaka
Copy link
Member

ZeWaka commented Mar 18, 2021

is this still wip

@ZeWaka ZeWaka marked this pull request as draft March 18, 2021 05:07
@zjdtmkhzt
Copy link
Contributor Author

Haven't done stuff to make, like, for instance, telecrystals trigger if you're made of telecrystal, so I should probably get to it.
I mean, it could be merged before that, just means some things won't really do much, it would be mostly cosmetic, but it could already be fun and find potential issues that players may have with it, if someone feels like merging.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2021

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Apr 3, 2021
@github-actions github-actions bot closed this Apr 10, 2021
@BatElite BatElite removed the E-Add-To-Wiki A PR that will require changes to the wiki label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Stale An inactive PR that has had no updates in the past two weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants