Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprites drinks.dmi #4058

Merged

Conversation

Arthur-Holiday
Copy link
Contributor

@Arthur-Holiday Arthur-Holiday commented Mar 18, 2021

[ADD TO WIKI]

About the PR

Makes reagents in a drinking glasses visually decay same way they do in beakers and resprites most stuff in drinks.dmi to be in correct perspective. I didn't touch most unused sprites.

Why's this needed?

Correct perspective good and visually decaying reagents are also very cool.

Changelog

(u)Arthur Holiday
(*)Resprited various drinking glasses and made them show the amount in them better.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Mar 18, 2021
@keywordlabeler keywordlabeler bot added the E-Add-To-Wiki A PR that will require changes to the wiki label Mar 18, 2021
@Carbadox
Copy link
Contributor

Pics to show off how it looks in the PR description would be dope

@Flaborized
Copy link
Contributor

these are good

@mordent-goonstation
Copy link
Contributor

mordent-goonstation commented Mar 18, 2021

Below refer to the icon states:

  • rum seems a bit too cartoony, second opinion from someone?
  • glass-round seems too rounded to me, i.e. curves back in too far.
  • tea0 and tea1 are both very tall cups, prefer a little squatter (or at least the ratio made so that they're wider)
  • glass-cocktail could use being sharper at the rim of the glass, looks like it sort of curves up at the top as-is.

@Arthur-Holiday
Copy link
Contributor Author

Sprite-0002

@Arthur-Holiday
Copy link
Contributor Author

tried to make "rum" look more like a bottle, changed the glasses based on feedback and made the tea cups 1 pixel shorter, they were only 2 pixels bigger than the current in game one, so I don't think they were too big, they need to be a little bigger to fit the wizard image too. hopefuly it is all better now. I am also posting images as requested. @mordent-goonstation

@mordent-goonstation
Copy link
Contributor

@MatheusIsNotAvailable I've added a changelog entry to the PR's description, using the name added to some of your other PRs. If this was wrong or whatever let me know and I'll get alter it.

@mordent-goonstation mordent-goonstation merged commit 131dae4 into goonstation:master Mar 21, 2021
@Carbadox Carbadox removed the E-Add-To-Wiki A PR that will require changes to the wiki label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Sprites Automatically applied on any .dmi or icons folder change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants