Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a GPS PDA program and adds it to the default PDA programs #4604

Merged
merged 1 commit into from May 7, 2021

Conversation

112358sam
Copy link
Contributor

@112358sam 112358sam commented May 6, 2021

[QoL][feature][input wanted]

About the PR

Adds a Space GPS program to the list of PDA programs and adds it to the list of default programs on all PDA's. The program can only get the user's coordinates and uses the same landmark notation as the separate GPS device. It does not interact with packets, navigate to locations, track other devices, or allow others to track the user.

Why's this needed?

After the removal of the port-a-sci PDA app summon feature, getting unexpectedly lost in the trench, asteroid belt, debris field, or far from the station is difficult to recover from. Being able to relay a user's own coordinates would enable fun rescue missions without having to comb the entire z-level. The limited feature set is intentional to keep the physical GPS useful and prevent packet nerds from tracking everyone on station.

Changelog

(u)112358sam
(*)Added a Space GPS program to the default list set of PDA programs.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 6, 2021
@keywordlabeler keywordlabeler bot added C-Feature A new feature or enhancements to existing features E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. C-QoL A quality of life improvement that makes the game easier to play labels May 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

Created discussion thread: https://forum.ss13.co/showthread.php?tid=16345

@112358sam
Copy link
Contributor Author

image
image
Some images of the program on the menu and open.

@penny64
Copy link
Contributor

penny64 commented May 7, 2021

I disagree about the no packets thing.

The users should be able to turn their GPS on or off, but if it's on and they're not using it they should risk exposure to revealing their location through command=status or similar

@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label May 7, 2021
@Kyle2143
Copy link
Contributor

Kyle2143 commented May 7, 2021

This is good. I merge.

@Kyle2143 Kyle2143 merged commit 34bbaef into goonstation:master May 7, 2021
github-actions bot pushed a commit that referenced this pull request May 7, 2021
@112358sam 112358sam deleted the PDA_GPS branch May 7, 2021 20:52
@DimWhat DimWhat removed the E-Add-To-Wiki A PR that will require changes to the wiki label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants