Slot machines directly use bank account balance

[112358sam]

[QoL] [input-wanted]

About the PR

Slot machines now directly use a player's bank account similar to vending machines. The withdraw to card and deposit from card functions are removed from the ATM as they were only used for slot machines. To maintain account security, slot machines now ask for a PIN before allowing play.

The slot machine UI now has the player cash in some amount from their account before play and cash out after play. Removing the card also cashes out all funds. This prevents someone with bank access from pulling someone's winnings while they are still playing.

Why's this needed?

Having two digital currencies is unintuitive and difficult for new players to learn. The withdraw to card feature is only used for slots and seems out of place with every other device using bank account funds.

Changelog

(u)112358sam
(+)Slot machines use bank account funds.
(+)ATMs no longer withdraw to and deposit from ID cards.

[RGBDeadSilent]

This does make it easier on new players, but it also makes it easier for antags to immediately embezzle the money directly out of your account.

HONK HONK HONK! JUSTIN FALKLIN JUST HIT IT BIG AND WON 1,000,000 CREDITS!

Let me just immediately steal that as a HoP antag, move it to somewhere I can easily pull it from, and you've now lost that money immediately.

At least the old way it was on the card, and the antag had a chance to move it to their account when they hit listening post to purchase things. (What other reasons are there to win big? Buying Station destroying pod weapons and AEX ammo thats what.)

[112358sam]

Didn't expect this to be contentious. I'll add the input-wanted label. I'll say that is a good point though. I couldn't think of any downsides while I was coding it. The counter could be that it would pretty quickly out the HoP as antag and the player can still withdraw cash to keep it safe. Not perfect though. I am interested to see where the consensus ends up.

[github-actions]

Created discussion thread: https://forum.ss13.co/showthread.php?tid=16647

[MarkNais]

As much as instant-embezzlement is a possibility, I personally don't find it to be a blocker.

[112358sam]

I've changed the slot machine to locally hold play funds until the card is ejected. I've edited the description accordingly. This should help deal with the embezzlement possibility.

[MarkNais]

Stored Funds is a neat idea. I assume you tested the changes.

[112358sam]

Stored Funds is a neat idea. I assume you tested the changes.

Yeah, I loaded it up and tested a variety of cases to make sure everything worked as intended.