Overhaul how sechuds' and prodocs' icon adding/removing works. #5359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerhazo
added
the
C-Code-Quality
github-actions
bot
added
the
size/L
ZeWaka
approved these changes
Jul 4, 2021
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
The idea behind the changelog entry was an immediate point of reference to a certain thing changing in case any issues happened that didn't appear in local testing as well as to bring to light that it's a thing now with the old method of adding images on a processing loop from a global list being deprecated. That being said if it still seems unnecessary I don't mind it being removed so if that's the case feel free to (or if it's a thing I must do give me a heads up and I shall). |
|
yolo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Uses client image groups added in #4789 to overhaul how assigning arrest/health icons to mobs wearing things like sechuds or prodocs works.
Currently, to deal with things like clients logging out/logging in, mobs swapping clients and whatnot processing loops are used to sanity-check constantly for whether the icons need to be added/removed. Invisibility changes are tracked in a similar fashion. This ends up with a lot of lines of repeating code for processing loops for every item that requires that functionality.
This PR instead makes use of signals to handle these events as they happen. It also moves a lot of the responsibility onto the forementioned image groups, drastically cutting down the amount of code required to make use of the icons.
There should be no noticeable difference from a player standpoint and all original functionality has been preserved.
Why's this needed?
Cleaner handling of adding arrest and health icons, with less repetitive code and no necessity of processing loops.
Changelog