Ports tgstation#58980: better Tooltip support #5881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tip; code tidy up of some touched interfaces (ChemDispenser, MixingDesk, PowerMonitor, SlotMachine)
boring-cyborg
bot
added
E-Docs
github-actions
bot
added
the
size/XL
mordent-goonstation
added
C-Code-Quality
| bet: wager, | ||
| })} /> | ||
| </Box> | ||
| <Stack vertical> |
There was a problem hiding this comment.
Definitely some out-of-scope changes in here, did them while trying to work out some of the layout things for the popper replacements. Happy to revert and do in a separate PR if needed; one of the perks of being a dev is that I can do what I want.
| @@ -1951,6 +1951,13 @@ __metadata: | |||
| languageName: node | |||
| linkType: hard | |||
|
|
|||
| "@popperjs/core@npm:^2.9.1": | |||
| version: 2.9.3 | |||
There was a problem hiding this comment.
tgstation locked to 2.9.2 because I guess that was what was available at the time. I'm fine with ours being ahead by a patch version.
ZeWaka
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Stackcomponent withinSlotMachineinterfaceWhy's this needed?