Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glow Stickers #5904

Merged
merged 3 commits into from Sep 13, 2021
Merged

Glow Stickers #5904

merged 3 commits into from Sep 13, 2021

Conversation

Sovexe
Copy link
Contributor

@Sovexe Sovexe commented Sep 5, 2021

About the PR

  • Adds Glow Stickers
  • stickers that glow when stuck to things
  • can be unstuck and restuck
  • do not give off any light when not stuck to something
  • Adds one box to Oshan mining hanger. No box for manta yet.
  • Box holds 20 stickers

image

Why's this needed?

  • Let miners place down glowing markers in the trench for lighting and navigational purposes

Changelog

(u)Sovexe
(*)New item, glow stickers. Stickers that glow when stuck to something. Now provided to undersea miners.

@Sovexe Sovexe requested a review from flrsh as a code owner September 5, 2021 03:48
@boring-cyborg boring-cyborg bot added A-Mapping A mapping change C-Sprites Automatically applied on any .dmi or icons folder change labels Sep 5, 2021
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 5, 2021
@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Sep 5, 2021
@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label Sep 5, 2021
@Arthur-Holiday
Copy link
Contributor

Maybe put them in a cargo crate?

Copy link
Contributor

@flrsh flrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Up to you if you want to put these in a QM crate, though I actually think spawning these on miners (#ifdef UNDERWATER_MAP) might be better, since that way they're guaranteed to have them and thus more likely to use them.

attack_hand(mob/user as mob)
user.lastattacked = user
if (src.attached)
if (user.a_intent == INTENT_HELP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like grab would make more sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these mimic sticky notes which use help

@ZeWaka
Copy link
Member

ZeWaka commented Sep 7, 2021

Consider: manta & OTHER_MAP

@Sovexe
Copy link
Contributor Author

Sovexe commented Sep 10, 2021

Very cool. Up to you if you want to put these in a QM crate, though I actually think spawning these on miners (#ifdef UNDERWATER_MAP) might be better, since that way they're guaranteed to have them and thus more likely to use them.

Giving them to miners could be good I'll look into that

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 11, 2021
@Sovexe Sovexe merged commit d48dd8b into goonstation:master Sep 13, 2021
@Sovexe Sovexe deleted the glow-stickers branch September 13, 2021 20:19
github-actions bot pushed a commit that referenced this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change E-Add-To-Wiki A PR that will require changes to the wiki size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants