Resprite critter gunbots #5923
Merged
Resprite critter gunbots #5923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
C-Sprites
github-actions
bot
added
the
size/XS
|
Could not get the glowing eyes to work in the same way cyborg heads work. SELFILLUM is nearly the same but doesn't quite have the same change in different lighting. If anyone could work out the way to implement that it would be nice. I copied the very simple implementation and sprites of Pali's PR and had 0 success. |
|
Looks good and fits resprite 👍 |
ZeWaka
reviewed
Sep 7, 2021
Comment on lines
+21
to
+25
| New() | ||
| . = ..() | ||
| var/image/eye_light = image(icon, "mars_sec_bot_eye") | ||
| eye_light.plane = PLANE_SELFILLUM | ||
| src.UpdateOverlays(eye_light, "eye_light") |
There was a problem hiding this comment.
so you're saying this doesn't work?
There was a problem hiding this comment.
Oh no that works, it's just pretty different to the implementation on borgs which use black pixels for eyes and put them on lighting plane.
goonstation/code/mob/living/silicon/robot.dm
Line 2590 in 697eb5d
ghost
approved these changes
Sep 19, 2021
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Resprites gunbots with sprites by Matheus.
Adds glowing red eyes.
Adds animated treads.
Why's this needed?
They fit the new borgs better!
Changelog