Prefab - Gnomish Warship #5987
Prefab - Gnomish Warship #5987
Conversation
…to gnome-prefab
boring-cyborg
bot
added
A-Mapping
github-actions
bot
added
the
size/L
keywordlabeler
bot
added
C-Feature
|
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
github-actions
bot
added
the
S-Stale
code/datums/commodity.dm
Outdated
| comtype = /obj/item/reagent_containers/food/drinks/drinkingglass/pitcher/pisscher | ||
| desc = "Botanist's friend and precursor for a great fertilizer... but why is it in a pitcher!?" | ||
| onmarket = 0 | ||
| price = 1000 |
There was a problem hiding this comment.
Probably more like 2000, since you can make 360u saltpetre.
There was a problem hiding this comment.
Remember that this is one of those items which you can't buy from David before you have completed his mini-quest, and you used to be able to do something similar in less than two minutes.
| /datum/commodity/splicer | ||
| comname = "LUCA 1005 - Splicer Upgrade" | ||
| comtype = /obj/item/plantModule/splicer | ||
| desc = "Increases PlantMaster Mk3 splicing chances by using the science behind the genome of the last universal common ancestor." | ||
| onmarket = 0 | ||
| price = 50000 | ||
| upperfluc = 10000 | ||
| lowerfluc = -10000 |
There was a problem hiding this comment.
Unsure about this, @Tarmunora thoughts?
| else | ||
| if (--plant_check < 1) | ||
| plant_check = initial(plant_check) | ||
| for (var/obj/machinery/plantpot/planter in view(7, src)) |
There was a problem hiding this comment.
| for (var/obj/machinery/plantpot/planter in view(7, src)) | |
| for (var/obj/machinery/plantpot/planter in view(3, src)) |
Should be significantly smaller.
There was a problem hiding this comment.
It's the same as for bees, because otherwise they might wander too far. What if I made them check for trays less frequently?
| var/obj/machinery/plantpot/work_target | ||
| var/work_bore = 40 | ||
|
|
||
| ai_think() |
There was a problem hiding this comment.
You should have them hibernate or go to sleep if there are no players around; otherwise they'll just keep processing and checking their surroundings, adding extra unnecessary load.
There was a problem hiding this comment.
Fair. I did not know sleep did that and thought it was just a visual thing. But also on the other hand trays might dry in the prefab if gnomes are not watering them... not like it really matters but it would be visually more pleasing I guess.
There was a problem hiding this comment.
Wait, I think the critter parent already does this on its own, unless I am completely mistaken.
github-actions
bot
added
the
S-Merge-Conflict
github-actions
bot
removed
the
S-Merge-Conflict
TTerc
removed
the
S-Stale
github-actions
bot
added
S-Merge-Conflict
|
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
github-actions
bot
added
the
S-Stale
|
oh right this was still up |
github-actions
bot
removed
the
S-Stale
github-actions
bot
removed
the
S-Merge-Conflict
|
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
github-actions
bot
added
the
S-Stale
TTerc
removed
the
S-Stale
github-actions
bot
added
the
S-Merge-Conflict
|
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
github-actions
bot
added
the
S-Stale
About the PR
This is a contest entry for https://forum.ss13.co/showthread.php?tid=16992
Summary:
The gnomish warship
The cockpit is fiercely defended by two very hungry maneaters. The engine room has been renovated into a laboratory for alien plant research. The ship is manned by two gnome critters, who keep the garden pretty. In the cockpit you can find the ship's merchant captain, David the Space Gnome!
David the Space Gnome
David sells many useful botany supplies, including fertilizers and strange seeds. He is quite stingy, so his wares don't come cheap! He himself buys honey (because it is tasty), human and monkey meat (to feed the maneaters), but not synth meat.
David the Spacegnome has two secret items, but he wont sell them to just anyone! In order to unlock his most valuable secret shop items, you have to show him a very high-class botany produce. He is not interested in herbs or other crap you might produce, he wants to see a quality snack!
Gnome critters
These helpful fellows water plants when they need it most. They also clear trays from dead plants, and very rarely plant seeds to empty hydroponic trays. Huggable. Unfortunately, they are mute.
Why's this needed?
This is a contest entry. Gnomes are cute.
The merchant sells many useful (yet expensive) tools for botanists to counteract some of the unintended side effects of piss nerfing -- botany actually suffered a lot from it and countless strats were invalidated when saltpetre output dropped by over 90%. You can get saltpetre through other means (such as QM, fabricating more GardenGears) but emptying dozens of tiny bottles into bigger containers makes it very tiresome. David sells saltpetre in larger bottles, making the process a bit easier (if you have the money).
The 50000 credit splicing module enables very interesting strategies which have not been feasible before. When installed to your Plantmaster Mk3, it improves its minimum splice chance from 0% to 30%. If you somehow get past the maneaters, and have the money for the module, then you have almost unlimited potential in your splices --- but failures are still possible.
Changelog