Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tgui-bench port #6272

Closed
wants to merge 6 commits into from
Closed

tgui-bench port #6272

wants to merge 6 commits into from

Conversation

ZeWaka
Copy link
Member

@ZeWaka ZeWaka commented Oct 12, 2021 •
edited

About the PR

ports tgstation/tgstation#61081

Why's this needed?

performance testing good

not currently working - opens IE and runs server with html but tests don't occur even though js is loaded and fetched

@boring-cyborg boring-cyborg bot added E-Docs Automatically applied on any .md change. A-UI Modifies UI in some way. Automatically applied on a change to tgui/ labels Oct 12, 2021
@ZeWaka ZeWaka added the E-DNM [Dev Only] Do Not Merge - can only be removed by the applier or with their explicit permission. label Oct 12, 2021
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict labels Oct 12, 2021
@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Oct 28, 2021
@ZeWaka
Copy link
Member Author

ZeWaka commented Oct 28, 2021

fuck you

@ZeWaka ZeWaka removed the S-Stale An inactive PR that has had no updates in the past two weeks label Oct 28, 2021
@mordent-goonstation
Copy link
Contributor

Looks fine. Bundle update.

@ZeWaka
Copy link
Member Author

ZeWaka commented Oct 30, 2021

dnm

@Zonespace27 Zonespace27 added the E-Certified-Organic Will not be marked stale. label Nov 8, 2021
@pali6
Copy link
Member

pali6 commented Feb 27, 2022

dnm

still DNM?

@ZeWaka
Copy link
Member Author

ZeWaka commented Feb 27, 2022

yes it doesn't work fully iirc

@ZeWaka
Copy link
Member Author

ZeWaka commented Feb 27, 2022

Just have to spend time debugging I don't have

@ZeWaka ZeWaka self-assigned this Apr 21, 2022
@boring-cyborg boring-cyborg bot added the C-Documentation Deals with *.md files or other docs label Aug 21, 2022
@ZeWaka ZeWaka removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Aug 21, 2022
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Aug 21, 2022
@github-actions github-actions bot added S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict and removed S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict labels Aug 24, 2022
@ruben-svensson ruben-svensson self-assigned this Nov 28, 2022
@ruben-svensson
Copy link
Contributor

Gonna pick this up, I'd like some benchmark for the board game project.

@ZeWaka ZeWaka closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mordent-goonstation mordent-goonstation mordent-goonstation approved these changes

Assignees

@ZeWaka ZeWaka

@ruben-svensson ruben-svensson

Labels
A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-Documentation Deals with *.md files or other docs E-Certified-Organic Will not be marked stale. E-DNM [Dev Only] Do Not Merge - can only be removed by the applier or with their explicit permission. E-Docs Automatically applied on any .md change. S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZeWaka @mordent-goonstation @pali6 @ruben-svensson @Zonespace27