Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes RNG from Pathogen Sweat Infection #6640

Closed

Conversation

Wisemonster
Copy link
Contributor

@Wisemonster Wisemonster commented Nov 10, 2021

[FEEDBACK]

About the PR

Makes it so instead of having an rng check to have the pathogen sweat apply it's on-touch effect (and, consequently, an infection chance), it instead checks if the user either has shoes on (or is a cow-person) when walking over it, or applies it's on-touch effect if crawled through.

Why's this needed?

I asked on discord about some of the problems with current patho, and one mention was that it was hard to deal with pathogens, because if you didn't have a full biosuit on all the time, you could randomly be infected. Part of this problem was that the sweat didn't check any kind of protection, unlike the pathogen clouds.

Changelog

(u)Wisemonster
(*)Pathogen sweat goo can now be avoided by walking over it while either wearing shoes or being a cow-person. Don't crawl in it, though. (Pathology is still not enabled)

@keywordlabeler keywordlabeler bot added the E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. label Nov 10, 2021
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 10, 2021
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=17501

@zjdtmkhzt
Copy link
Contributor

Might wanna add your name in the changelog!

Also, no one goes barefoot except cows, which are protected, so this seems like it might make puddles basically useless?

@zjdtmkhzt zjdtmkhzt added the C-Balance Balance changes, buffs and nerfs label Nov 10, 2021
@Wisemonster
Copy link
Contributor Author

Might wanna add your name in the changelog!

Also, no one goes barefoot except cows, which are protected, so this seems like it might make puddles basically useless?

Yea, I'll probably make the goo a bit slippery so that if you arn't walking, you might slip and get infected.

@Wisemonster
Copy link
Contributor Author

Apparently the goo is already slippery. Gonna check to make sure it'll infect if you slip in it, and if it's slippery enough

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Nov 25, 2021
@TTerc TTerc removed the S-Stale An inactive PR that has had no updates in the past two weeks label Nov 26, 2021
@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Dec 11, 2021
@github-actions github-actions bot closed this Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Stale An inactive PR that has had no updates in the past two weeks size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants