Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move normal human initialization to initializeBioholder #6894

Merged
merged 2 commits into from Dec 24, 2021

Conversation

zjdtmkhzt
Copy link
Contributor

@zjdtmkhzt zjdtmkhzt commented Dec 11, 2021

About the PR

fix #6886
fix #6115

The names were assigned after the ID was made, because they were in a SPAWN_DBG().
I moved them to initializeBioholder, things seem to work now.

Also removed the SPAWN_DBGs from the parts for the job-specific normal humans, it seems to work fine without them.

Why's this needed?

bugs bad

@zjdtmkhzt zjdtmkhzt added the P-Major A bug that significantly impacts the usage of a feature. label Dec 11, 2021
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2021
@zjdtmkhzt zjdtmkhzt added the E-DNM [Dev Only] Do Not Merge - can only be removed by the applier or with their explicit permission. label Dec 11, 2021
@zjdtmkhzt
Copy link
Contributor Author

Still some issues with JobEquipSpawned() while the person has no hud. >.>

@zjdtmkhzt zjdtmkhzt removed the E-DNM [Dev Only] Do Not Merge - can only be removed by the applier or with their explicit permission. label Dec 11, 2021
@ZeWaka ZeWaka merged commit 146714d into goonstation:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Major A bug that significantly impacts the usage of a feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latejoin antags spawn with a blank ID. random event antag bank accounts do not work
2 participants