Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizards now struggle with tech like flashes and batons. #7104

Closed
wants to merge 2 commits into from

Conversation

DimWhat
Copy link
Contributor

@DimWhat DimWhat commented Jan 7, 2022

[balance]

About the PR

This PR gives wizards a trait called "Technological Ineptitude" that makes them have the effects of clumsy on specifically batons and flashes. I do have desire to make wizards also fumble with guns but it seems there is nothing really there for clumsy at the moment.
This change should make wizards less inclined to use security tools to become unstoppable and instead destroy security tools.

Why's this needed?

Wizard is currently extremely powerful when they get tasers and batons to an absurd degree since they can warp anywhere to charge them. The end result is not very fun to fight against as wizards usually just grab batons after using magic missile and steal them for their own use.

Changelog

(u)DimWhat
(*)Wizards now fumble with batons and flashes

@keywordlabeler keywordlabeler bot added the C-Balance Balance changes, buffs and nerfs label Jan 7, 2022
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2022
@@ -405,7 +405,7 @@
//never should happen but w/e

//make it harder for them clowns...
if (src.can_stun() == 1 && user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50))
if (src.can_stun() == 1 && user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50) || (user.traitHolder.hasTrait("tech_inept") && prob (50)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (src.can_stun() == 1 && user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50) || (user.traitHolder.hasTrait("tech_inept") && prob (50)))
if (src.can_stun() && ((user.bioHolder?.HasEffect("clumsy") && prob(50)) || (user.traitHolder?.hasTrait("tech_inept") && prob(50))))

@@ -242,7 +242,7 @@
user.show_message("<span class='alert'>[M] seems to be warded from attacks!</span>")
return

if (src.can_stun() == 1 && user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50))
if (src.can_stun() == 1 && user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50) || (user.traitHolder.hasTrait("tech_inept") && prob (50)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (src.can_stun() == 1 && user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50) || (user.traitHolder.hasTrait("tech_inept") && prob (50)))
if (src.can_stun() && ((user.bioHolder?.HasEffect("clumsy") && prob(50)) || (user.traitHolder?.hasTrait("tech_inept") && prob(50))))

@@ -218,7 +218,7 @@

src.is_active = !src.is_active

if (src.can_stun() == 1 && user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50))
if (src.can_stun() == 1 && user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50) || (user.traitHolder.hasTrait("tech_inept") && prob (50)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (src.can_stun() == 1 && user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50) || (user.traitHolder.hasTrait("tech_inept") && prob (50)))
if (src.can_stun() && ((user.bioHolder?.HasEffect("clumsy") && prob(50)) || (user.traitHolder?.hasTrait("tech_inept") && prob(50))))

@@ -208,7 +208,7 @@
if (src.l_time && world.time < src.l_time + 10)
return

if (user?.bioHolder?.HasEffect("clumsy") && prob(50))
if (user?.bioHolder?.HasEffect("clumsy") && prob(50) || (user.traitHolder.hasTrait("tech_inept") && prob (50)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (user?.bioHolder?.HasEffect("clumsy") && prob(50) || (user.traitHolder.hasTrait("tech_inept") && prob (50)))
if ((user?.bioHolder?.HasEffect("clumsy") && prob(50)) || (user?.traitHolder?.hasTrait("tech_inept") && prob(50)))

@@ -95,7 +95,7 @@
if (t.loc:sanctuary)
user.visible_message("<span class='alert'><b>[user]</b> tries to use [src], cannot quite comprehend the forces at play!</span>")
return
if (user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50))
if (user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50) || (user.traitHolder.hasTrait("tech_inept") && prob (50)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (user.bioHolder && user.bioHolder.HasEffect("clumsy") && prob(50) || (user.traitHolder.hasTrait("tech_inept") && prob (50)))
if ((user.bioHolder?.HasEffect("clumsy") && prob(50)) || (user.traitHolder?.hasTrait("tech_inept") && prob(50)))

@flappybatpal
Copy link
Contributor

Good idea, I'd be interested to see what can be done with guns.

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jan 24, 2022
@DimWhat DimWhat closed this Jan 24, 2022
@DimWhat
Copy link
Contributor Author

DimWhat commented Jun 5, 2022

Reopening cause i'm feeling like this should probably get worked on again.

@DimWhat DimWhat reopened this Jun 5, 2022
@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Jun 6, 2022
@DimWhat
Copy link
Contributor Author

DimWhat commented Jun 6, 2022

yeah gonna have to tear out all my garbage and start from scratch.

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jun 21, 2022
@github-actions github-actions bot closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs S-Stale An inactive PR that has had no updates in the past two weeks size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants