Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new traitor item: cursed glue #7386

Closed

Conversation

TobleroneSwordfish
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish commented Feb 4, 2022

[FEATURE] [BALANCE] [ADD TO WIKI] [INPUT WANTED]

About the PR

Adds a bottle of cursed glue to the traitor buylist for 3TC.
When used on a player it glues a worn item onto them (sets cant_self_remove and cant_other_remove), the item glued depends on the users body targeting. It cannot be used on yourself. The glue can be flipped in hand to make it unglue all items on the target instead.
It has 5 uses, and the glue is only used up when actually sticking something down.

image image

Body part targeting works like this:
Either arm = gloves glued
Either leg = shoes glued
Chest = outer suit first, then jumpsuit
Head = helmet first, then mask, then glasses, then headset
Targeting drops through, so if a higher piece of clothing is already glued, then the next one down will be targeted. This allows panicked spam clicking to glue everything in that location.

This is a bit convoluted, but I wanted to make sure this was for sticking things to other people rather than preventing your own items being removed, and also restrict which slots items could be stuck to.

The only item the glue refuses to stick is straightjackets, because that feels a little too powerful. Blindfolds and muzzles work fine though.

Things the glue can't remove: cluwne, slasher, horse and waldo gear, anything with cant_drop. (Can't test waldo things so it gets a "probably works" if this ever comes up again)
All other cursed items can be removed using the glue (obsidian crown, syndicate hat etc.)

Why's this needed?

Pros:

  • funny clothing related gimmicks
  • the captain chasing a traitor around the station to get the glue bottle back with cat ears stuck to their head
  • makes some underutilized matsci item effects more useful (telecrystal shoes anyone?)

Cons:

  • possible to use this with a buddy to stick armour, headgear and so forth to yourself
  • I'm not an artist so the sprite might not be great
  • the long list of items this is extremely broken with that I haven't though of

Changelog

(u)LeahTheTech
(*)Added a new 3TC traitor item: cursed glue. Used to stick clothes to people.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Feb 4, 2022
@keywordlabeler keywordlabeler bot added E-Add-To-Wiki A PR that will require changes to the wiki C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features labels Feb 4, 2022
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2022
@Kanthes
Copy link

Kanthes commented Feb 4, 2022

Exceedingly funny idea.

Might be problematic with Magnetic Boots as well, as they prevent dragging when worn.

@Sbmhawk
Copy link
Contributor

Sbmhawk commented Feb 4, 2022

You can aggressive grab with magboots

@ThatFiveGuys
Copy link
Contributor

You should be able to glue items and when someone picks those items up it becomes an item arm.

@TobleroneSwordfish
Copy link
Contributor Author

You should be able to glue items and when someone picks those items up it becomes an item arm.

That's how I originally imagined it, but it would be far too debilitating for the person who picks up a random item and would also make it an auto-buy for c-saber rampages etc.

@MetricDuck
Copy link
Contributor

MetricDuck commented Feb 4, 2022

Tested on local:

  • Cursed horsemask can be unequipped and placed in pocket. Unintended?
  • Horse cultist robes & Tommys gear can be unequipped and messed with even with cant_drop. Feels odd, consider making an exception for things with cant_drop. There's also an ishorse() proc.
  • Slasher and Waldo can be stripped entirely. Slasher especially should probably get an exception. There's an isslasher() proc.

Untested:

  • Looks like it can entirely unstick moustache / brass gauntlet / syndie clown / ancient armour / obby crown / owl suit / syndie hat / cursed amongus suit / hotdog suit. This stuff seems fine IMO though I'm sure someone will find a way to abuse something.
  • Dawson and "The Smiling Man" can be stripped entirely. I wasn't even sure how to spawn these so eh...

Overall looks great though! Love the little animation

@NightmareChamillian
Copy link
Contributor

Wouldn't it make more sense if it was magical glue?

@TobleroneSwordfish
Copy link
Contributor Author

Tested on local:

  • Cursed horsemask can be unequipped and placed in pocket. Unintended?
  • Horse cultist robes & Tommys gear can be unequipped and messed with even with cant_drop. Feels odd, consider making an exception for things with cant_drop. There's also an ishorse() proc.
  • Slasher and Waldo can be stripped entirely. Slasher especially should probably get an exception. There's an isslasher() proc.

Untested:

  • Looks like it can entirely unstick moustache / brass gauntlet / syndie clown / ancient armour / obby crown / owl suit / syndie hat / cursed amongus suit / hotdog suit. This stuff seems fine IMO though I'm sure someone will find a way to abuse something.
  • Dawson and "The Smiling Man" can be stripped entirely. I wasn't even sure how to spawn these so eh...

Overall looks great though! Love the little animation

thanks for doing all that, I'll go through and add some more checks (I need to learn every is-something macro at some point, there are so many)

@TobleroneSwordfish
Copy link
Contributor Author

I have added more checks and updated the PR to show all the cases I can think of. It can still remove Dawson and "The Smiling Man" clothing, maybe they should just have cant_drop anyway, not sure if that would break something.

Wouldn't it make more sense if it was magical glue?

Most of the time things are stuck to you it's some kind of curse (horse mask, cluwne, adventure zone items), so I think cursed glue makes sense?

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2022
@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Feb 24, 2022
@keywordlabeler keywordlabeler bot added the E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. label Feb 24, 2022
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=18135

Copy link
Contributor

@flrsh flrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think things are unremovable and removable for a reason, but more importantly, I don't like the idea of players forcing other players to wear things they might not want to wear, which this item would encourage.

@TobleroneSwordfish
Copy link
Contributor Author

Well, yes, I can't really deny that this has potential for abuse, but there are already multiple ways to force someone to wear something (restraints, normal cursed items, mindslaving etc.) which can be abused in much the same way.
At the end of the day I understand not wanting to give admins more headaches.

@github-actions github-actions bot added S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict and removed S-Stale An inactive PR that has had no updates in the past two weeks labels Feb 26, 2022
@flrsh
Copy link
Contributor

flrsh commented Mar 3, 2022

Yeah, there are other things that can be abused, but this uniquely and specifically encourages that sort of behavior.

At the end of the day I understand not wanting to give admins more headaches.

Basically yeah :shelterfrog:

@flrsh flrsh closed this Mar 3, 2022
@Studenterhue Studenterhue removed the E-Add-To-Wiki A PR that will require changes to the wiki label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants