Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Med, Tech, and Research Assistant jobs more viable for learning (also headset changes to barber and musician) #7547

Merged
merged 4 commits into from Mar 28, 2022

Conversation

Yellow-Mushroom
Copy link
Contributor

@Yellow-Mushroom Yellow-Mushroom commented Feb 19, 2022

About the PR

Changes:

Research Assistant is given:

  • no outfit change
  • a science PDA
  • a research headset
  • 2 job slots

Medical Assistant is given:

  • Scrubs! (random chance of every flavor except maroon and flowers)
  • Red shoes
  • a medical PDA
  • a medical headset
  • 2 job slots

Technical Assistant is given:

  • an engineering headset
  • a special Technical assistant PDA (which gets station repair alerts)
  • 2 job slots

Misc changes:
Barber is given

  • a civilian headset

Musician is given

  • a civilian headset

Why's this needed?

Research and Medical assistants are being started off with basic PDA's and basic headsets, making it very difficult for them to both communicate with their team and also function without their jobs PDA. While PDA cartridges are ridiculously cheap, starting someone who is learning without them is not constructive to that learning process.

The goal of this change is to make learning as a medical, research, or technical assistant an easier time for that player, with more tools and better forms of communication

Also barbers and musicians were given headsets as they are as civilian as they get

Changelog

(u)Yellow
(*)Changes up Research Assistant, Medical Assistant, and Technical Assistant to make them more applicable for those who want to learn
(+)Gives both Barbers and Musicians civilian headsets

@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Feb 19, 2022
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 19, 2022
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=18100

@Yellow-Mushroom Yellow-Mushroom changed the title Makes Med, Tech, and Research Assistant jobs more viable for learning Makes Med, Tech, and Research Assistant jobs more viable for learning (also headset changes to barber and musician) Feb 19, 2022
@Yellow-Mushroom Yellow-Mushroom marked this pull request as ready for review February 20, 2022 19:37
@Yellow-Mushroom
Copy link
Contributor Author

There is a merge conflict but I will fix it when I get home

@Yellow-Mushroom
Copy link
Contributor Author

Ready for review!

@pali6
Copy link
Member

pali6 commented Feb 20, 2022

Have you actually checked if your code works? From looking at how the lists for slots are handled it seems like it would explicitly crash without weights.

code/datums/jobs.dm Outdated Show resolved Hide resolved
code/datums/jobs.dm Outdated Show resolved Hide resolved
code/datums/jobs.dm Outdated Show resolved Hide resolved
code/datums/jobs.dm Outdated Show resolved Hide resolved
@Yellow-Mushroom
Copy link
Contributor Author

Have you actually checked if your code works? From looking at how the lists for slots are handled it seems like it would explicitly crash without weights.

😔 I have 0 memory if I tested medass after adding the scrubs. ill test it rn

@pali6
Copy link
Member

pali6 commented Feb 20, 2022

Probably out of the scope of this PR but I always felt like the "X Assistant" jobs should have the Staff Assistant jumpsuit except with the blue highlights replaced by the colour associated with that department.

@Yellow-Mushroom
Copy link
Contributor Author

Yellow-Mushroom commented Feb 20, 2022

Now Research ass looks now (didnt change except the headset)
image

Now Technical ass looks now (didn't change except the headset)
image

Now Medical ass can look now:
image

Now Medical ass can also look now:
image

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Mar 8, 2022
@pali6 pali6 removed the S-Stale An inactive PR that has had no updates in the past two weeks label Mar 13, 2022
@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Mar 28, 2022
@TTerc TTerc merged commit ee8da49 into goonstation:master Mar 28, 2022
github-actions bot pushed a commit that referenced this pull request Mar 28, 2022
@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs E-Add-To-Wiki A PR that will require changes to the wiki E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Stale An inactive PR that has had no updates in the past two weeks size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants