Resprites Item Sprites For Fireworks and Sparklers #7882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
C-Sprites
github-actions
bot
added
the
size/XS
Studenterhue
removed
the
E-Add-To-Wiki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Resprites the item sprites for fireworks and sparklers. Doesn't touch in-hands or the sparkler box. Does add a small burning out animation when sparklers burn out (the gif under shows it looping but it doesn't loop like that in-game)
Why's this needed?
I wanted to draw fireworks so I drew these, I think they look a bit better so I'm PRing them. More specifically, they're a little thicker (which should make clicking on them nicer) and follow the guidelines/existing artstyle a bit more closely with color choice and outlines. I also wanted to make the sparkler have a sparkler-y animation instead of a pulse-y look. Nothing too major though