New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using emergency security alert now triggers maptext + a sound effect #8323
Conversation
Created discussion thread: https://forum.ss13.co/showthread.php?tid=18585 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add the sound to the soundcache as per the audio guidelines but aside from that the sound itself is fine. Not commenting on balance or anything though, I dunno how much something like this is needed so I'll let other devs weigh in
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally I'm a fan
Hm I wonder if it could maybe have a different outline colour to distinguish it from speech more? |
Hm. The sfx doesn't sound terribly alert-like to me. |
Maybe an overlay, like a flash from a PDA or a glow of sorts would work better than just text? You'd have to figure out how to convey "help", maybe by pairing with text of a different font or layout than speech (like with health scans), but a visual element would aid a lot in meaning |
I feel like by relying on a visual element like a flash of light, you 1. Dont tell new players what that thing means immediately, unlike text which they can just read. Any knowledge of that indicator will be based on you knowing that indicator instead of something you can quickly figure out. And 2. Would give too much visual noise, distracting people from the sec off to try and figure out what that thing was. Its important to note this maptext is both larger and has different opacity and lack of color compared to speech so while messing around found it pretty distingushable. Its basically the same font cargo price analyzer uses except a bit smaller so if you want to take a look at it just use that. Specific font/color/size is definitely changeable, when i was making this i imagined the maptext to be a robotic voice saying it (i should probably add text in sidebar to accompany it now that i mention it). |
Maybe it could be like a speech bubble but red or something? idk |
The alert sound doesn't give me "emergency alert" vibes. I'm a little on the fence about the one click security alerts in general at the moment, we swing between stacked sec teams where it can be infamously difficult for antags to do anything hostile and 2-3 officers who get picked off. |
These alerts get by far the most usage for experienced sec, with newer sec not responding and all that jazz. I think this pr will hurt new players minimally |
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
Echoing other commenters - a more "alert"-like sfx and some modification to the maptext (make it red and a bit more transparent?) would be good. If you're working on other things and would rather close this for now, that's fine too. |
Anyways text should now be a lot more distinct then speech (updated description of pr with a new image of it.) |
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
About the PR
Pressing the emergency security alert button plays this sound (https://freesound.org/people/stwime/sounds/545360/), and does this maptext:
Why's this needed?
The security alert can easily have a massive shift in the combat dynamic, with it easily causing a rush of security officers to arrive to an area with only the touch of a single button. This gives people nearby a warning, so they can choose to retreat or stay put accordingly.
Changelog