Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes wizards unable to blink while incapacitated #8465

Closed
wants to merge 4 commits into from
Closed

Makes wizards unable to blink while incapacitated #8465

wants to merge 4 commits into from

Conversation

EchoFive1409
Copy link

[BALANCE]
[INPUT WANTED]

About the PR

Makes it so wizards can't blink while incapacitated in anyway(Stun, knocked out, etc.). This is due to the fact that wizards currently can blink away with only a 10 second cooldown continually while stunned.

Why's this needed?

Wizards with both blink and forceshield can be essentially impossible to pin down and actually fight. This should make it a lot more possible to do so.

Changelog

(u)Drewmajor11
(+)Made it so wizards are unable to blink while incapacitated

@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels May 5, 2022
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

Created discussion thread: https://forum.ss13.co/showthread.php?tid=18705

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 5, 2022
@EchoFive1409
Copy link
Author

Accidentally briefly synced code from another change, think it should be undone now but it might show as modifying.

@EchoFive1409
Copy link
Author

I synced it again. I think it's fully fixed? Then again I am totally inept with github.

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2022
@@ -14,6 +14,9 @@
if(!holder)
return

if(is_incapacitated(holder.owner))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth mentioning that this will still allow them to blink while handcuffed. Use can_act() instead if this is unintentional.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, that bit is intentional, I feel like unable to blink while cuffed would be a bit too far.

@flappybatpal flappybatpal added the E-Add-To-Wiki A PR that will require changes to the wiki label May 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jun 6, 2022
@github-actions github-actions bot closed this Jun 13, 2022
@TTerc TTerc removed the E-Add-To-Wiki A PR that will require changes to the wiki label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Stale An inactive PR that has had no updates in the past two weeks size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants