Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Onomatopoeic trait #8717

Closed

Conversation

TobleroneSwordfish
Copy link
Contributor

[FEATURE]

About the PR

Adds a new 1 cost trait, Onomatopoeic, which causes you to add onomatopoeic sound effects to actions occasionally.
Also moves the moving var from clown cars to all /obj/vehicles to allow for "Zooom" sound effects when riding segways etc.

Current actions that cause the trait to trigger:

  • Using a fire extinguisher
  • Eating
  • Drinking
  • Attacking a mob/critter
  • Riding a vehicle
  • Firing a gun or pod laser
  • Activating any kind of police siren
  • Hitting someone over the head with a plate or tray

Please suggest more!

Why's this needed?

Suggested here: https://forum.ss13.co/showthread.php?tid=18852, I thought it was neat.
It's 1 cost because it will definitely get annoying if everyone has it.

Changelog

(u)LeahTheTech (suggested by BadShot)
(*)Added a new trait, Onomatopoeic. It causes you to occasionally vocalise your actions using various onomatopoeia (google it).

@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label May 24, 2022
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label May 24, 2022
@TobleroneSwordfish TobleroneSwordfish changed the title Added Onomatopoeic trait Adds Onomatopoeic trait May 24, 2022
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 24, 2022
@flrsh
Copy link
Contributor

flrsh commented Jun 4, 2022

I'm personally not a fan but I'll defer to other devs if they have strong opinions.

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jun 19, 2022
@flrsh flrsh closed this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change S-Stale An inactive PR that has had no updates in the past two weeks size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants