Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for auto-injector to chemmaster #8770

Conversation

Aivaria
Copy link
Contributor

@Aivaria Aivaria commented May 27, 2022

[input wanted]

About the PR

It adds the option of boxed and single auto-injectors to the chemmaster. Includes the Hypospray whitelist (emagging chemmaster makes it ignore the whitelist).
Adds a big container without limits, that doesnt fit in the belt slot (weight 3), and a small one with a capacity of 3, which can be added to belt

Why's this needed?

i always thought its an missing feature, as these could easily be handed out to people.

Changelog

(u)Aivaria + littleBugHunter
(*)Added the options for single and multiple auto-injectors to chemmaster. Chemicals are restricted by whitelist, but can be emagged to allow any chem.

…oxes, removed extended whitelist. added sprite for injector container (thanks and credits to littleBugHunter!)
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label May 27, 2022
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 27, 2022
@DisturbHerb
Copy link
Contributor

maybe change the changelog to something more like this

(u)Aivaria + littleBugHunter
(*)Added the options for single and multiple auto-injectos to chemmaster

Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tgui chemmaster when

code/obj/item/generic_box.dm Outdated Show resolved Hide resolved
code/modules/chemistry/Chemistry-Machinery.dm Outdated Show resolved Hide resolved
code/modules/chemistry/Chemistry-Machinery.dm Outdated Show resolved Hide resolved
@Wisemonster
Copy link
Contributor

Might wanna add the emag function to the changelog.

Aivaria and others added 5 commits May 28, 2022 00:20
fix duplicate and wrong name

Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>
fix typo

Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>
fix typo

Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>
@flrsh
Copy link
Contributor

flrsh commented May 29, 2022

I don't think the chemmaster should be able to create autoinjectors. It doesn't really make sense to me and I like autoinjectors only being found in portananomeds given their convenience. I am also not a fan of emagging letting you use any chems - autoinjectors are already the only chemical vehicle you can really trust without a spectroscopic scanner.

@Aivaria
Copy link
Contributor Author

Aivaria commented May 29, 2022

I don't think the chemmaster should be able to create autoinjectors. It doesn't really make sense to me and I like autoinjectors only being found in portananomeds given their convenience. I am also not a fan of emagging letting you use any chems - autoinjectors are already the only chemical vehicle you can really trust without a spectroscopic scanner.

currently they would behave equivalent to one use, low volume hyposprays.
The intention (from medic and rp play view) is the option, to add an alternative to pills you can savely hand out to your fellow miners or security, they can use in case of emergency. (like potassium iodide to miners, in case they get radiated). they are quite low volume, and one use, so you wouldnt hand out a bottle of like 10 pills, and never see that person again, instead you hand out like 1 or a box of 3, so the patient might come back, and so get some interaction again.
Also, since it uses the hypospray whitelist, the chemicals usualy shouldnt be (too) dangerous in them (there are even more dangerous one available in porta-med.

But honestly, i dont know in which way it might affect gameplay in the end. i would imagine, that botany and medbay on RP servers would profit from this (already had some feedback, that love this idea), but i dont know how this would end in the hands of an baddie or how it behaves on classic, as i lack the experience in those field.

@Aivaria
Copy link
Contributor Author

Aivaria commented May 29, 2022

Maybe, to add an different argument - currently you could also use patches kinda the same way, like you could use the auto-injector in this PR. with the difference, these give an one shot injection, of up to 10u, while patches add a content of up to 30u each to the person over time. To get this more fun, you can use patches 'out lof the box' (literaly). If the chemmaster is emagged, it can create any chem patch, without them having a delay while attaching them to a person.

i would say, lets test how this ends out.
if its too over powered or abused, we may shrink things down, like reduce that size 3 box, to size 2 ( it was also the first size i had in my mind when working with them ), and increase the weight class of the 'unlimited' box, so it doesnt fit into the backpack anymore (and maybe make it so, it contains the smaller size boxes, so you cant run arround with an giant box, and pump chem after chem into people from the large box).
If thats still well to overused / abused, then my offer is: ping me in discord, and i provide the patch to remove this feature asap i can.

@TDHooligan
Copy link
Contributor

probly worth a discussion thread. i've thought of the idea while adding the cans to the ChemMaster. I think they intrude on the territory of the hypospray a little much, and if you add small-sized boxes of 3 you functionally have something better than a hypospray until you need to refill them.
also as flourish says - they currently are the only reliable source of medicines.

@keywordlabeler keywordlabeler bot added the E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. label May 30, 2022
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=18952

@UrsulaMejor
Copy link
Contributor

Don't want the ability to emag them to bypass whitelist. Use a hypospray for that; autoinjectors should be reliable "safe" things that do not need to be questioned.

@ZeWaka
Copy link
Member

ZeWaka commented May 31, 2022

not a fan re: emily, flourish

@flrsh
Copy link
Contributor

flrsh commented Jun 2, 2022

Devs don't seem to be a fan of this, closing.

@flrsh flrsh closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Sprites Automatically applied on any .dmi or icons folder change E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants