Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Permeability coefficient into an object property. #9166

Merged
merged 5 commits into from
Jun 17, 2022

Conversation

DimWhat
Copy link
Contributor

@DimWhat DimWhat commented Jun 15, 2022

[Experimental] [balance] [wiki] [input]

About the PR

Reworks how permeability_coefficient works into a standard object property much like fire prot and changes up the amount of chems blocked by certain clothes. This is definately gonna need more work and testing on what values are good for blocking chems but I think players seeing how much percentage of chems they are going to block will help them understand chems better.

Under our current system, a scientist in default gear will be completely immune to chemicals rendering biosuits moot.

During my testing It appears that a default assistant has 15% and a default scientist has 42% chemicals blocked from splashes. I find this to be much more preferable as it will make people more inclined to get biosuits and similar. Although, I must add again that these values are NOT set in stone and will likely change as time goes on.

Why's this needed?

Permeability is a mess, it really doesn't make sense nor is it told to the player on how it works. Hell, it was hard for ME to figure out how it worked while investigating the values. This should help players get a better understanding on how much something blocks beaker splashing and let players slap together some higher chem resistant gear if they cannot get bio suits.

Changelog

(u)DimWhat
(*)Reworked permeability into chemical resistance which has been applied to several clothing items. Please report any weirdness with chemical splashing.

@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. labels Jun 15, 2022
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict labels Jun 15, 2022
@DimWhat DimWhat marked this pull request as ready for review June 16, 2022 20:15
@keywordlabeler keywordlabeler bot added E-Add-To-Wiki A PR that will require changes to the wiki E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Jun 16, 2022
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=19095

@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Jun 16, 2022
@Tarmunora Tarmunora self-requested a review June 17, 2022 00:54
@Tarmunora
Copy link
Member

imo, latex gloves should be bumped up a fair bit (15% or so) and masks removed outright (they protect you from smoke inhalation anyways) because latex gloves have a large opportunity cost compared to a gas mask (means not wearing insuls etc vs gasmask just being the best-in-slot to begin with).

otherwise, the numbers here are probably workable.

@Tarmunora Tarmunora merged commit 6b0ae1d into goonstation:master Jun 17, 2022
github-actions bot pushed a commit that referenced this pull request Jun 17, 2022
BatElite pushed a commit to BatElite/goonstation that referenced this pull request Jun 20, 2022
…9166)

* half way there

* it compiles

* calculation tweaks

* yass suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. E-Add-To-Wiki A PR that will require changes to the wiki E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants