Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ctrl-I As The *twirl Hotkey #9908

Merged
merged 3 commits into from Aug 24, 2022

Conversation

Mister-Moriarty
Copy link
Contributor

@Mister-Moriarty Mister-Moriarty commented Jul 27, 2022

[Feature] [QoL]

About the PR:

As is described, the formerly unused Ctrl-I is now used as the *twirl hotkey.

Why's this needed?

A widely requested hotkey, for all those that want to try to put their firearm away in suave style only to shoot themselves in the foot.
Currently unbinded Ctrl-keys: Ctrl-C, Ctrl-J, Ctrl-K, Ctrl-M, Ctrl-O, Ctrl-U, and Ctrl-V.

Changelog:

(u)Mr. Moriarty
(*)Added Ctrl-I as the *twirl hotkey.

@keywordlabeler keywordlabeler bot added the C-QoL A quality of life improvement that makes the game easier to play label Jul 27, 2022
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2022
@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Jul 27, 2022
@TTerc
Copy link
Member

TTerc commented Jul 27, 2022

afaik, on tg controls, ctrl+R is the flip hotkey while R is for throwing

@Mister-Moriarty
Copy link
Contributor Author

Mister-Moriarty commented Jul 27, 2022

Hmm, what would make the most sense as a TG *twirl hotkey, or should I leave it unbinded for TG?
It would be best to have it consistant across all keybind settings, much like the other emotes though.

Ctrl-C, Ctrl-I, Ctrl-J, Ctrl-K, Ctrl-M, Ctrl-O, Ctrl-U, and Ctrl-V are all currently unbinded.

@ZeWaka ZeWaka added the E-Freeze-Exempt🧊 Exempt from the current feature freeze label Jul 31, 2022
@ZeWaka ZeWaka added the A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities label Aug 10, 2022
@Mister-Moriarty Mister-Moriarty changed the title Adds Ctrl-R As The *twirl Hotkey Adds Ctrl-I As The *twirl Hotkey Aug 19, 2022
@ZeWaka ZeWaka merged commit d06f26d into goonstation:master Aug 24, 2022
github-actions bot pushed a commit that referenced this pull request Aug 24, 2022
@Mister-Moriarty Mister-Moriarty deleted the twirl-hotkey branch August 25, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play E-Freeze-Exempt🧊 Exempt from the current feature freeze size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants