Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os:cmd instead of Erlang ports #23

Merged
merged 19 commits into from
Sep 28, 2020
Merged

os:cmd instead of Erlang ports #23

merged 19 commits into from
Sep 28, 2020

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

Attempting to [Fix #16] [Fix #21] [Fix #22], by replacing Erlang ports with os:cmd as discussed in two of the linked Issues.

paulo-ferraz-oliveira
paulo-ferraz-oliveira commented Sep 27, 2020
View reviewed changes
rebar.config Outdated Show resolved Hide resolved
gootik
gootik reviewed Sep 28, 2020
View reviewed changes
Copy link
Owner

@gootik gootik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for all the cleanup you did. This was the first ever thing I made in Erlang and it was due for some love.

.travis.yml Show resolved Hide resolved
rebar.config Outdated Show resolved Hide resolved
src/rebar_cmd.app.src Show resolved Hide resolved
src/rebar_cmd.app.src Show resolved Hide resolved
src/rebar_cmd.app.src Outdated Show resolved Hide resolved
src/rebar_cmd.app.src Show resolved Hide resolved
src/rebar_cmd_prv.erl Show resolved Hide resolved
src/rebar_cmd_prv.erl Show resolved Hide resolved
src/rebar_cmd_prv.erl Show resolved Hide resolved
@paulo-ferraz-oliveira
Copy link
Contributor Author

I pushed a fix for the tests. I also ended up having erlfmt inside its own profile, because it'll only run in Erlang/OTP 21+ and it was thus restricting the "plugin" which can support from 19.3 on (the same versions rebar3 supports).

@paulo-ferraz-oliveira
Copy link
Contributor Author

paulo-ferraz-oliveira commented Sep 28, 2020 •
edited
Loading

Hurrah, tests passed.
Don't merge just yet. I'm tweaking the README.md.

Edit: you can see how it looks here.

@gootik
Copy link
Owner

gootik commented Sep 28, 2020

nicely done. I'll merge this now and anything that you like to improve on can be separate PRs.
Again, thank you so much for doing all of this. really appreciate it

@gootik gootik merged commit df31071 into gootik:master Sep 28, 2020
@paulo-ferraz-oliveira
Copy link
Contributor Author

If you feel it's OK, could you release it and possibly publish it to Hex? Thanks.

@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/os_cmd branch September 28, 2020 21:33
@paulo-ferraz-oliveira paulo-ferraz-oliveira mentioned this pull request Oct 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gootik gootik gootik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use os:cmd instead of Erlang ports Make command timeout configurable Multiple inline commands don't run
2 participants
@paulo-ferraz-oliveira @gootik