Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not rewrite ~ #2083

Closed
dominikschulz opened this issue Dec 30, 2021 · 0 comments · Fixed by #2496
Closed

Do not rewrite ~ #2083

dominikschulz opened this issue Dec 30, 2021 · 0 comments · Fixed by #2496
Labels
cleanup Code hygiene
Milestone
1.x.x

Comments

@dominikschulz
Copy link
Member

We should likely not rewrite ~ when parsing path value but just removing it would break some use cases so this needs to be done carefully.
@dominikschulz dominikschulz added the cleanup Code hygiene label Dec 30, 2021
@dominikschulz dominikschulz added this to the 1.x.x milestone Dec 30, 2021
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Dec 27, 2022
@dominikschulz
Do not rewrite ~
1919ab2 
Fixes gopasspw#2083

RELEASE_NOTES=[ENHANCEMENT] Do not rewrite ~.

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Dec 27, 2022
@dominikschulz
Do not rewrite ~
a7735d6 
Fixes gopasspw#2083

RELEASE_NOTES=[ENHANCEMENT] Do not rewrite ~.

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz mentioned this issue Dec 27, 2022
Merged
dominikschulz added a commit that referenced this issue Dec 28, 2022
@dominikschulz
Do not rewrite ~ (#2496)
1ba67f7 
* Do not rewrite ~

Fixes #2083

RELEASE_NOTES=[ENHANCEMENT] Do not rewrite ~.

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

* Honor GOPASS_HOMEDIR

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Code hygiene
Projects
None yet
Milestone
1.x.x
Development

Successfully merging a pull request may close this issue.

Do not rewrite ~ dominikschulz/gopass
1 participant
@dominikschulz