Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gitconfig] Support multivars #2457

Closed
2 of 5 tasks
dominikschulz opened this issue Dec 7, 2022 · 0 comments · Fixed by #2476
Closed
2 of 5 tasks

[gitconfig] Support multivars #2457

dominikschulz opened this issue Dec 7, 2022 · 0 comments · Fixed by #2476
Assignees
@dominikschulz
Labels
feature Enhancements and new features
Milestone
1.x.x

Comments

@dominikschulz
Copy link
Member

dominikschulz commented Dec 7, 2022 •
edited

pkg/gitconfig should support multivars. We need this to properly support multiple domain aliases pointing to the same domain.

  • Ensure high test coverage for the current implementation to avoid regressions
  • Add tests covering all current gopass use cases
  • Multi-var config support
  • Multi-var accessors (reading)
  • (optional) Multi-var accessors (writing)
@dominikschulz dominikschulz added the feature Enhancements and new features label Dec 7, 2022
@dominikschulz dominikschulz self-assigned this Dec 7, 2022
@dominikschulz dominikschulz added this to the 1.x.x milestone Dec 7, 2022
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Dec 17, 2022
@dominikschulz
Support MultiVars
2ce7f36 
Fixes gopasspw#2457

RELEASE_NOTES=[ENHANCEMENT] gitconfig: Support MultiVars

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz mentioned this issue Dec 17, 2022
Merged
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Dec 25, 2022
@dominikschulz
Support MultiVars
3a6f6c3 
Fixes gopasspw#2457

RELEASE_NOTES=[ENHANCEMENT] gitconfig: Support MultiVars

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit that referenced this issue Dec 28, 2022
@dominikschulz
Support MultiVars (#2476)
5845b2e 
* Support MultiVars

Fixes #2457

RELEASE_NOTES=[ENHANCEMENT] gitconfig: Support MultiVars

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

* Add getter and fix tests

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

* Add GetAll getters

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

* Add multiple-insert tests

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

* Fix multi get/set handling

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
feature Enhancements and new features
Projects
None yet
Milestone
1.x.x
Development

Successfully merging a pull request may close this issue.

Support MultiVars dominikschulz/gopass
1 participant
@dominikschulz