Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

q doesn't abort as advertised #2490

Closed
thatlittleboy opened this issue Dec 25, 2022 · 1 comment · Fixed by #2491
Closed

q doesn't abort as advertised #2490

thatlittleboy opened this issue Dec 25, 2022 · 1 comment · Fixed by #2491
Assignees
@dominikschulz
Labels
bug Defects
Milestone
1.15.3

Comments

@thatlittleboy
Copy link

thatlittleboy commented Dec 25, 2022 •
edited

Summary

The text prompt says "(q to abort)", but when I press "q", gopass proceeds to open up $EDITOR to create a new secret instead.

Steps To Reproduce

Exactly as the image shows. Just gopass edit <query> where query returns a list of candidate secrets, then press q. Then vim (or EDITOR) will pop up prompting me to create a new password/secret.

Expected behavior

q should abort, i.e., don't do anything and exit gopass. Not proceed with creating a secret.

Environment

  • OS: Mac OS Monterey
  • OS version: Darwin [redacted] 21.6.0 Darwin Kernel Version 21.6.0: Wed Aug 10 14:25:27 PDT 2022; root:xnu-8020.141.5~2/RELEASE_X86_64 x86_64
  • gopass Version: gopass 1.15.2 go1.19.4 darwin amd64
  • Installation method: brew

Additional context

nil
@dominikschulz dominikschulz self-assigned this Dec 25, 2022
@dominikschulz dominikschulz added the bug Defects label Dec 25, 2022
@dominikschulz dominikschulz added this to the 1.15.3 milestone Dec 25, 2022
@dominikschulz
Copy link
Member

That used to work. Let me check what's wrong.

dominikschulz added a commit to dominikschulz/gopass that referenced this issue Dec 25, 2022
@dominikschulz
Abort fuzzy search on edit if requested
0ffd977 
Fixes gopasspw#2490

RELEASE_NOTES=[BUGFIX] Honor fuzzy search abort

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz mentioned this issue Dec 25, 2022
Merged
dominikschulz added a commit that referenced this issue Dec 26, 2022
@dominikschulz
Abort fuzzy search on edit if requested (#2491)
d2c03f5 
Fixes #2490

RELEASE_NOTES=[BUGFIX] Honor fuzzy search abort

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
bug Defects
Projects
None yet
Milestone
1.15.3
Development

Successfully merging a pull request may close this issue.

Abort fuzzy search on edit if requested dominikschulz/gopass
2 participants
@dominikschulz @thatlittleboy