Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsck --decrypt ignores config core.autosync false #2495

Closed
DEvil0000 opened this issue Dec 27, 2022 · 1 comment · Fixed by #2497
Closed

fsck --decrypt ignores config core.autosync false #2495

DEvil0000 opened this issue Dec 27, 2022 · 1 comment · Fixed by #2497
Assignees
@dominikschulz
Labels
bug Defects
Milestone
1.15.3

Comments

@DEvil0000
Copy link

Summary

As mentioned in #2459 fsck --decrypt does not honor core.autosync config set to false

Steps To Reproduce

gopass config core.autosync false
//gopass config core.autoimport false //not relevant
//verified config is set
gopass fsck --decrypt

Expected behavior

should honor config and not push to git repo, manual sync should be needed after fsck

Environment

  • OS: fedora 37
  • OS version: 6.0.14-300.fc37.x86_64
  • gopass Version: master
  • Installation method: go install from master used the latest package before
  • BTRFS

Additional context

core.autoimport config works as expected
@dominikschulz
Copy link
Member

The setting should be honored. If not it's a bug.

I'll try to reproduce and if I can it should be easy to fix.

@dominikschulz dominikschulz self-assigned this Dec 27, 2022
@dominikschulz dominikschulz added the bug Defects label Dec 27, 2022
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Dec 27, 2022
@dominikschulz
Honor core.autosync for all current git push operations
fa39ff9 
Fixes gopasspw#2495

RELEASE_NOTES=[BUGFIX] Honor core.autosync

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz mentioned this issue Dec 27, 2022
Merged
@dominikschulz dominikschulz added this to the 1.15.3 milestone Dec 27, 2022
dominikschulz added a commit that referenced this issue Dec 28, 2022
@dominikschulz
Honor core.autosync for all current git push operations (#2497)
f63c2d1 
Fixes #2495

RELEASE_NOTES=[BUGFIX] Honor core.autosync

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
bug Defects
Projects
None yet
Milestone
1.15.3
Development

Successfully merging a pull request may close this issue.

Honor core.autosync for all current git push operations dominikschulz/gopass
2 participants
@dominikschulz @DEvil0000