Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopass cannot sync on fossilfs #2516

Closed
dertuxmalwieder opened this issue Jan 15, 2023 · 10 comments · Fixed by #2549
Closed

gopass cannot sync on fossilfs #2516

dertuxmalwieder opened this issue Jan 15, 2023 · 10 comments · Fixed by #2549
Assignees
@dominikschulz
Labels
feature Enhancements and new features
Milestone
1.x.x

Comments

@dertuxmalwieder
Copy link

Related discussion: #2022

A gopass store that uses fossilfs cannot synchronize with a remote Fossil repository.

Reproducing the problem(s):

  1. Initialize gopass with Fossil and age: gopass setup --crypto age --storage fossilfs
  2. Run gopass
  3. Type sync

Expected behavior:

fossil sync is run.

> fossil help sync
Usage: fossil sync ?URL? ?options?

Synchronize all sharable changes between the local repository and a
remote repository.  Sharable changes include public check-ins and
edits to wiki pages, tickets, forum posts, and technical notes.

If URL is not specified, then the URL from the most recent clone, push,
pull, remote, or sync command is used.  See "fossil help clone" for
details on the URL formats.

Actual behavior:

fs pull and push ... Skipped (no Git repo) (no changes)
@dominikschulz dominikschulz added this to the 1.x.x milestone Jan 29, 2023
@dominikschulz dominikschulz self-assigned this Jan 29, 2023
@dominikschulz dominikschulz added the feature Enhancements and new features label Jan 29, 2023
@dominikschulz
Copy link
Member

That should be easy to support and I thought I already tested this. But possible that it never properly worked. Fossilfs is really very experimental.

@dertuxmalwieder
Copy link
Author

I know, that’s why I tested. :-)

@ckolumbus
Copy link
Contributor

ckolumbus commented Jan 30, 2023 •
edited

I've run into the same issue... and i'm also interested in using age/fossil combo in order to easily distribute credentials without the overhead (esp avoiding gpg).
And I'm definitely in for testing this

@dominikschulz
Copy link
Member

Looking at the code this should be already supported.

Could you try it again with debug logging enabled, please?
Set GOPASS_DEBUG_LOG=/some/file.log.

@dertuxmalwieder
Copy link
Author

It looks like - at least on Windows - no log is created...?

@dominikschulz
Copy link
Member

Supporting Fossil isn't as easy as it should be. No matter from which ISP I always get random "this IP is blocked for abuse" errors on fossil-scm.org ... 🤦

dominikschulz added a commit to dominikschulz/gopass that referenced this issue Feb 9, 2023
@dominikschulz
Improve and fix fossilfs sync
29ede92 
The simple update-push-pull workflow with two stores and a
fossil server works now. Still needs a lot of testing.

Fixes gopasspw#2516

RELEASE_NOTES=[BUGFIX] Fix fossilfs sync

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz mentioned this issue Feb 9, 2023
Merged
dominikschulz added a commit that referenced this issue Feb 9, 2023
@dominikschulz
Improve and fix fossilfs sync (#2549)
0684e6a 
The simple update-push-pull workflow with two stores and a
fossil server works now. Still needs a lot of testing.

Fixes #2516

RELEASE_NOTES=[BUGFIX] Fix fossilfs sync

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@ckolumbus
Copy link
Contributor

Supporting Fossil isn't as easy as it should be. No matter from which ISP I always get random "this IP is blocked for abuse" errors on fossil-scm.org ... 🤦

How do you test this? Maybe I can help with alternative test setups.

@dominikschulz
Copy link
Member

Not sure how I end up getting these messages. But for now I think I have all the docs I need.

One thing however, if we're talking about testing fossil: We could use some contributed integration tests :)

@dertuxmalwieder
Copy link
Author

I’m not quite good with tests, sadly.

@dominikschulz
Copy link
Member

Manual testing is also very valuable, of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
feature Enhancements and new features
Projects
None yet
Milestone
1.x.x
Development

Successfully merging a pull request may close this issue.

Improve and fix fossilfs sync dominikschulz/gopass
3 participants
@dertuxmalwieder @ckolumbus @dominikschulz