Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to git commit: git is not initialized #2543

Closed
lefuturiste opened this issue Feb 8, 2023 · 4 comments · Fixed by #2547
Closed

Failed to git commit: git is not initialized #2543

lefuturiste opened this issue Feb 8, 2023 · 4 comments · Fixed by #2547
Assignees
@dominikschulz
Labels
bug Defects
Milestone
1.15.4

Comments

@lefuturiste
Copy link

lefuturiste commented Feb 8, 2023 •
edited

Summary

When initializing the gopass store, I get an error "Failed to git commit"

$ go pass init
🍭 Initializing a new password store ...
🔑 Searching for usable private Keys ...
⚠ Hint: Use 'gopass init <subkey> to use subkeys!'
❌ Failed to git commit: git is not initialized
❌ Failed to export missing public keys: some keys failed

Steps To Reproduce

gopass init

Expected behavior

That I get no errors

Environment

  • OS: Arch linux
  • OS version: Linux hostname 5.15.90-1-lts #1 SMP Tue, 24 Jan 2023 12:46:03 +0000 x86_64 GNU/Linux
  • gopass Version: gopass 1.15.3 go1.19.5 linux amd64
  • Installation method: pacman community package

Additional context
@lefuturiste
Copy link
Author

Ok my bad I have to use gopass setup instead of gopass init

@lefuturiste lefuturiste changed the title Failed to git commit Failed to git commit: git is not initialized Feb 8, 2023
@dominikschulz
Copy link
Member

Actually gopass init should also work ...

@dominikschulz dominikschulz reopened this Feb 8, 2023
@dominikschulz dominikschulz self-assigned this Feb 8, 2023
@dominikschulz
Copy link
Member

This seems to be more of a cosmetic error (but still a bug).

I can mostly reproduce this, i.e. gopass init works as expected, the store is in a good state afterwards but I do still get the annoying error message. Will fix that.

@dominikschulz dominikschulz added the bug Defects label Feb 9, 2023
@dominikschulz dominikschulz added this to the 1.15.4 milestone Feb 9, 2023
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Feb 9, 2023
@dominikschulz
Hide unnecessary git error messages during gopass init
e2fc5e4 
These don't impact the setup workflow but confuse users.

Fixes gopasspw#2543

RELEASE_NOTES=[BUGFIX] Hide harmless git error messages.

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz mentioned this issue Feb 9, 2023
Merged
dominikschulz added a commit that referenced this issue Feb 9, 2023
@dominikschulz
Hide unnecessary git error messages during gopass init (#2547)
4a9fe68 
* Hide unnecessary git error messages during gopass init

These don't impact the setup workflow but confuse users.

Fixes #2543

RELEASE_NOTES=[BUGFIX] Hide harmless git error messages.

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

* Ignore module with valid but strangly formatted license from checks

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

* Fix integration tests

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

---------

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@lefuturiste
Copy link
Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
bug Defects
Projects
None yet
Milestone
1.15.4
Development

Successfully merging a pull request may close this issue.

Hide unnecessary git error messages during gopass init dominikschulz/gopass
2 participants
@dominikschulz @lefuturiste